[#9,#14,#17,irods/irods#7265] Minor reorganization + CMake TLC

irods / irods_auth_plugin_pam_interactive

BSD 3-Clause "New" or "Revised" License

2 stars 5 forks source link

Closed SwooshyCueb closed 4 months ago

SwooshyCueb commented 5 months ago

In service of #9 In service of irods/irods#7265 Addresses #14 Addresses #17 Supersedes #20

removed unused main.cpp
reorganized project
created object library target for auth_check_wrapper.cpp
created interface library target for ipam_client.hpp
quoted paths in cmake
Removed unneeded CMAKE_SHARED_LINKER_FLAGS_INIT and CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT
Added missing CMAKE_EXE_LINKER_FLAGS_INIT and CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT
Swapped quotes to angle brackets on irods includes
Removed references to nonexistent include directory from cmake
Removed unneeded pam_conversation.hpp include from handshake_session.cpp
Bumped irods version and removed exact requirement
Updated CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST_ADDITION
Split into server and client packages (server package depends on client package)
Replaced PAM find_library logic with a new find module
Switched to find_package for fmt and spdlog

SwooshyCueb commented 5 months ago

Now that we've got 4.3.2 out, I think this PR is ready for review

korydraughn commented 4 months ago

Incompatible due to the CMake changes?

alanking commented 4 months ago

Yes. Specifically, the new specified minimum version is 4.3.2.

alanking commented 4 months ago

Eh, perhaps that just comes with the territory of building something yourself. Just wanted to make sure we considered it.

korydraughn commented 4 months ago

I see. Given this project is external, we can adjust it so that it compiles against 4.3.1 and later.

I think it would be trivial given we did that with the GenQuery2 repo.

@SwooshyCueb What would it take to make this compile against 4.3.1 too? Is it just adjusting the minimum iRODS version?

SwooshyCueb commented 4 months ago

@SwooshyCueb What would it take to make this compile against 4.3.1 too? Is it just adjusting the minimum iRODS version?

I think it may require some conditional logic around fmt and spdlog handling in CMake. I'm not sure though.

korydraughn commented 4 months ago

Okay. Let's make that happen so people aren't required to upgrade to 4.3.2.

SwooshyCueb commented 4 months ago

Okay. Let's make that happen so people aren't required to upgrade to 4.3.2.

Roger that. It might take me a bit though as I don't currently have a workflow for building against 4.3.1.

SwooshyCueb commented 4 months ago

I've restored build compatibility with 4.3.1. If there are no objections, I will #.

korydraughn commented 4 months ago

Yep, squash and pound to taste.

korydraughn commented 4 months ago

Please make sure the issue numbers are correct too.

SwooshyCueb commented 4 months ago

#'d