search

irods / irods_auth_plugin_pam_interactive

2 stars 3 forks source link

Unconditional `#include` of `handshake_session.hpp` in `pam_interactive.cpp` #23

Open SwooshyCueb opened 2 months ago

SwooshyCueb commented 2 months ago

pam_interactive.cpp unconditionally includes handshake_session.hpp: https://github.com/irods/irods_auth_plugin_pam_interactive/blob/f07902328fc4b686b2f79da152c8fb89f579696c/src/pam_interactive.cpp#L30 The only place anything in handshake_session.hpp is referenced outside of a #ifdef RODS_SERVER conditional is a using statement: https://github.com/irods/irods_auth_plugin_pam_interactive/blob/f07902328fc4b686b2f79da152c8fb89f579696c/src/pam_interactive.cpp#L86 All other usage/references is/are inside #ifdef RODS_SERVER conditionals.

We should move the #include and the using statement inside #ifdef RODS_SERVER conditionals.