Closed SwooshyCueb closed 2 months ago
This line in auth_check_wrapper.cpp is of some concern: https://github.com/irods/irods_auth_plugin_pam_interactive/blob/f07902328fc4b686b2f79da152c8fb89f579696c/src/auth_check_wrapper.cpp#L16
auth_check_wrapper.cpp
strlen
std::
std::strlen
<cstring>
#include
std::size_t
uint32_t
n
static_cast
std::uint32_t
<cstdint>
@SwooshyCueb Please close if completed.
This line in
auth_check_wrapper.cpp
is of some concern: https://github.com/irods/irods_auth_plugin_pam_interactive/blob/f07902328fc4b686b2f79da152c8fb89f579696c/src/auth_check_wrapper.cpp#L16strlen
is in thestd::
namespace, so should be referred to asstd::strlen
.std::strlen
comes from<cstring>
, but<cstring>
is never#include
d.std::strlen
returnsstd::size_t
, notuint32_t
. It appears intentional thatn
is auint32_t
, sostatic_cast
should be used.uint32_t
is in thestd::
namespace, so should be referred to asstd::uint32_t
.std::uint32_t
comes from<cstdint>
, but<cstdint>
is never#include
d.