search

irods / irods_auth_plugin_pam_interactive

2 stars 3 forks source link

chlUpdateIrodsPamPassword call #3

Closed ll4strw closed 5 months ago

ll4strw commented 5 months ago

I am compiling the pam_interactive plugin against iRODS v4.3.1 and I have noticed that a call to chlUpdateIrodsPamPassword at https://github.com/irods/irods_auth_plugin_pam_interactive/blob/9973475682c0833f5522c53ef4f523ee2492c9e5/src/pam_interactive.cpp#L567 does not match its signature at

https://github.com/irods/irods/blob/0462e56685aed0c3b73b791feef4f5aa7c92b294/server/icat/include/irods/icatHighLevelRoutines.hpp#L197

In particular, the argument std::size_t _password_buffer_size seems to be missing. Am I wrongly mixing and matching versions, or this plugin needs an update? Thanks in advance.

korydraughn commented 5 months ago

You are correct that there's a signature mismatch.

The signature changed in iRODS 4.3.1 and the plugin has not been updated to reflect that yet. The signature that you're referring to in the current implementation of the plugin matches the signature in iRODS 4.3.0.

We'll get that taken care of.

ll4strw commented 5 months ago

I can make a pull request if that is allowed.

korydraughn commented 5 months ago

Of course. We welcome contributions.

ll4strw commented 5 months ago

BTW, I just tested the plugin with https://github.com/ll4strw/pam_deviceauthgrant and I am rather happy it works as it should. Well done!