Don't autoload the .phar file by default.

iron-io / iron_mq_php

PHP client for IronMQ.

www.iron.io

BSD 2-Clause "Simplified" License

89 stars 43 forks source link

Don't autoload the .phar file by default. #13

Closed taylorotwell closed 11 years ago

taylorotwell commented 11 years ago

Hi, I'm the creator / maintainer of Laravel, one of the most popular PHP frameworks. We ship an IronMQ driver for our unified Queue API in the latest version of the framework.

We're having some issues with the .phar file being included in the Composer setup. Currently, you have the .phar file in your autoload array of the composer.json file. Can you remove that? If someone is using the library via Composer, there would be no need to use the .phar.

thousandsofthem commented 11 years ago

Few questions:

What the issues? Is them framework-specified? Will them effect other users?
Is it good for you: change autoloading .phar file to autoloading class file
What is proposed way to load classes for regular composer user

taylorotwell commented 11 years ago

The issue is that auto-loading the .phar like that will cause weird characters to be dumped to the screen.

Really all you need to do is swap the autoload from the .phar to the .class file, like this: http://paste.laravel.com/fKI

It won't affect your other users at all. After you change that, I would suggest making a new minor version tag so that Composer will see a new stable version.

thousandsofthem commented 11 years ago

Make sense. Will do.

taylorotwell commented 11 years ago

Thanks!

thousandsofthem commented 11 years ago

@taylorotwell test it please.

"iron-io/iron_mq": "1.4.2"

taylorotwell commented 11 years ago

Looks good! Thanks