Closed mike182uk closed 1 year ago
Hey,
I'm getting Notice: Undefined property: IronMQ::$use_keystone when using the v3 branch.
Notice: Undefined property: IronMQ::$use_keystone
The reason i'm getting this error is because https://github.com/iron-io/iron_core_php/pull/12 has not been merged but https://github.com/iron-io/iron_mq_php/pull/38 has been merged. IMO both of these PR's should of been merged at the same time as they are dealing with the same bit of functionality.
I noticed a fix for this was recently merged (https://github.com/iron-io/iron_mq_php/pull/42) but i don't think this is the correct way to handle the problem. When https://github.com/iron-io/iron_core_php/pull/12 finally gets merged there is going to be a redundant isset($this->use_keystone) which will most likely get forgot about and left in.
isset($this->use_keystone)
A better approach may be to either get https://github.com/iron-io/iron_core_php/pull/12 merged and revert https://github.com/iron-io/iron_mq_php/pull/42 or revert https://github.com/iron-io/iron_mq_php/pull/38 and https://github.com/iron-io/iron_mq_php/pull/42 until https://github.com/iron-io/iron_core_php/pull/12 can be merged?
Hey,
I'm getting
Notice: Undefined property: IronMQ::$use_keystonewhen using the v3 branch.The reason i'm getting this error is because https://github.com/iron-io/iron_core_php/pull/12 has not been merged but https://github.com/iron-io/iron_mq_php/pull/38 has been merged. IMO both of these PR's should of been merged at the same time as they are dealing with the same bit of functionality.
I noticed a fix for this was recently merged (https://github.com/iron-io/iron_mq_php/pull/42) but i don't think this is the correct way to handle the problem. When https://github.com/iron-io/iron_core_php/pull/12 finally gets merged there is going to be a redundant
isset($this->use_keystone)which will most likely get forgot about and left in.A better approach may be to either get https://github.com/iron-io/iron_core_php/pull/12 merged and revert https://github.com/iron-io/iron_mq_php/pull/42 or revert https://github.com/iron-io/iron_mq_php/pull/38 and https://github.com/iron-io/iron_mq_php/pull/42 until https://github.com/iron-io/iron_core_php/pull/12 can be merged?