Closed irongut closed 3 years ago
Arabic, Comoros (ar_KM) Arabic, World (ar_001) Arabic, Djibouti (ar_DJ) Arabic, Western Sahara (ar_EH) Arabic, Eritrea (ar_ER) Arabic, Mauritania Arabic, Palestine Arabic, Saudi Arabia (ar_SA) Arabic, Somalia Arabic, South Sudan Arabic, Sudan Arabic, Chad
Arabic (ar) Arabic, United Arab Emirates (ar_AE) Arabic, Bahrain (ar_BH) Arabic, Algeria (ar_DZ) Arabic, Egypt (ar_EG) Arabic, Iraq (ar_IQ) Arabic, Jordan (ar_JO) Arabic, Kuwait (ar_KW) Arabic, Lebanon (ar_LB) Arabic, Libya (ar_LY) Arabic, Morocco (ar_MA) Arabic, Oman Arabic, Qatar Arabic, Syria Arabic, Tunisia Arabic, Yemen
NewsArticleConverter.cs
parses each article publish date & time on line 73. Passing a culture to the Convert.ToDateTime()
call should fix the issue. Similar to recent fix for BGS Tick.
The Islamic Hijri calendar is the official calendar in countries around the Gulf, especially Saudi Arabia. Based on a lunar cycle and dates from the Prophet Muhammad's flight from Makkah to Madinah. The Islamic year (AH) averages 354 days and recedes by about 11 days a year against the Gregorian calendar.
Calendar | Date |
---|---|
Hijri | 08 / 09 / 1442 |
GREGORIAN | 20 / 04 / 2021 |
An issue remains with the date displayed by the consuming app not appearing.
The relevant Label controls are bound to NewsArticle.PublishDate
which needs culture in a DateTime.ToString()
call.
Bug Report
GalNet News does not work with Arabic, Saudi Arabia (ar_sa) calendar.
App Center Issue 1550929719
Stack Trace
To Reproduce
Steps to reproduce the behavior:
Expected Behavior
GalNet parses & displays correctly.
Additional Context
Priorities, server status, BGS tick & CGs have no date issues but year is 42.
Arabic (ar_ar) & Arabic, United Arab Emirates (ar_ua) do not have these issues. Other Arabic calendars should be tested.
Firebase Screenshots
Linked To
51 Errors with non-Western calendars
63 Standings broken with some Arabic calendars
irongut/EliteALD Issue 304 GalNet & Standings broken with some Arabic calendars