isaacs / github

Just a place to track issues and feature requests that I have for github
2.2k stars 129 forks source link

Gist comments and mentions don't trigger notifications #21

Closed max-mapper closed 5 years ago

max-mapper commented 11 years ago

this used to work.

to reproduce:

Bouke commented 9 years ago

:shipit: !

deoren commented 9 years ago

+1

raindev commented 9 years ago

Looking forward to see it implemented🐰

LaurensRietveld commented 9 years ago

+1

jennybc commented 9 years ago

+1

prateek05 commented 9 years ago

+1

naholyr commented 9 years ago

:+1:

nealtodd commented 9 years ago

+1

tijptjik commented 9 years ago

:+1:

VincentDondain commented 9 years ago

+1

dongshengbc commented 9 years ago

:+1:

amdrew commented 9 years ago

:+1:

an0 commented 9 years ago

I want this, too. But will GitHub team see this?

bethesque commented 9 years ago

I don't believe so. I recommend contacting them directly with a polite request. My email did actually get responded to by a human, even if they only said "your request has been noted".

In the meantime, I wrote this fairly ugly but workable stopgap solution that uses a ruby script and a launchd configuration: https://github.com/bethesque/gist-notifications

kramerc commented 9 years ago

@bethesque I wrote something similar about a year ago and mentioned it here. However, mine is more geared towards adding an entry to the crontab.

bethesque commented 9 years ago

:+1:

mwinche commented 9 years ago

+1

an0 commented 9 years ago

@bethesque but GitHub does encourage us to come here: https://github.com/contact.

bethesque commented 9 years ago

Yes, that's where I sent my request from.

Xesued commented 9 years ago

+1

yckart commented 9 years ago

:+1:

Nate-Wilkins commented 9 years ago

:+1:

jessedavidson commented 9 years ago

+1

cansadadeserfeliz commented 9 years ago

:+1:

phibo23 commented 9 years ago

+1

afred commented 9 years ago

:+1:

sheharyarn commented 9 years ago

:+1: :+1: :+1:

gogromat commented 9 years ago

+1

noamross commented 9 years ago

+1

weissjeffm commented 9 years ago

Pretty please :+1:

rmzelle commented 9 years ago

:star: +1 :star:

joech4n commented 9 years ago

:+1:

cyrusdavid commented 9 years ago

:sparkles: :+1: :shipit: :sparkles:

stefansundin commented 9 years ago

Hello all. I made a quick app that gives you an RSS feed of your gist comments. Use it freely here: https://gh-rss.herokuapp.com/

If you like it, don't be afraid to send me some money for a coffee. :)

tannerhodges commented 9 years ago

@stefansundin Wow, thanks! This is perfect. Used this Zapier to get email notifications too: https://zapier.com/zapbook/rss/email/544/get-email-alert-from-rss-feed/

joech4n commented 9 years ago

@stefansundin That's great, thank you! Here's an IFTTT Recipe for email alerts, too.

rosenfeld commented 9 years ago

For some reason it doesn't seem to generate a valid Atom format for my own feeds. Any ideas, @stefansundin?

stefansundin commented 9 years ago

@rosenfeld Oops, looks like I'm not escaping ampersands, that's why the feed is not validating. I'll try to fix it later today.

As some might have noticed, it is not compiling the markdown to HTML or inserting smileys. The most important job it has is to notify you, which works well now. If people continue to be interested and I get some donations, I will work on fixing smaller things like this.

stefansundin commented 9 years ago

@rosenfeld It should work now. All HTML should now be escaped.

rosenfeld commented 9 years ago

Yes, thank you very much, @stefansundin. This already solves an important part of the problem with the lack of gist notifications by Github and I will be using that feed until Github implements it properly. I will also spread the word whenever I comment in someone's else gist :) It would be awesome if I could also subscribe to some particular gist not owned by me that I could be interested on the conversation. Maybe someone might be interested in creating some Chrome extension that would display some "subscribe" icon to the github gists :) Anyway, congrats for the initiative :)

rey commented 9 years ago

Yeah this is really awesome -- thanks. I'll absolutely buy you a beer.

Sent from my silly iPhone

On 29 Jan 2015, at 19:32, Rodrigo Rosenfeld Rosas notifications@github.com wrote:

Yes, thank you very much, @stefansundin. This already solves an important part of the problem with the lack of gist notifications by Github and I will be using that feed until Github implements it properly. I will also spread the word whenever I comment in someone's else gist :) It would be awesome if I could also subscribe to some particular gist not owned by me that I could be interested on the conversation. Maybe someone might be interested in creating some Chrome extension that would display some "subscribe" icon to the github gists :) Anyway, congrats for the initiative :)

— Reply to this email directly or view it on GitHub.

stefansundin commented 9 years ago

@rosenfeld All of your ideas can be implemented. In the future I intend to add notifications when people fork your stuff and neglect to PR the changes back to you. As for a Chrome extension, these days I try to make those things as good old Greasemonkey/Tampermonkey userscripts, mostly because Google is no longer allowing local installations of extensions.

Right now I'm outputting all of the comments, if performance suffers then I might decide to limit them to the most recent 30 or so, or maybe drop them after a month has passed. But I don't mind stress testing the website for now.

akulakhan commented 9 years ago

need a way to get comments on secret gists too, would be nice.. for now, I just tell people to not expect me to read their comments.

bethesque commented 9 years ago

Thats the reason I'm still using my hacky gist-notifications script instead of the more elegant RSS solution from stefansundin. Hurry up Github!

stefansundin commented 9 years ago

Okay, I am hereby announcing a donation goal. If people collectively pledge $100, I will implement secret gist comments. Read all the details here: https://github.com/stefansundin/github-activity/issues/1

ihrwein commented 9 years ago

:+1: for this feature

brock commented 9 years ago

Just submitted a feature request to Github again, after StackOverflow told me a link that I'd shared had gotten over 25 views. Tracked it down to this gist that had a few comments.

My request:

| I reeeeeally reeeeeeeeeally would like to be notified when somebody comments on one of my gists. Will resort to scraping them in the meantime if I must. Felt bad when I had multiple comments on an old gist and hadn't responded to them.

calid commented 9 years ago

This just bit me, I'm surprised this is clearly such a low priority bug...

jimmygle commented 9 years ago

:+1:

st4lk commented 9 years ago

:+1: