isaacs / github

Just a place to track issues and feature requests that I have for github
2.21k stars 129 forks source link

Gist comments and mentions don't trigger notifications #21

Closed max-mapper closed 5 years ago

max-mapper commented 11 years ago

this used to work.

to reproduce:

khoubyari commented 9 years ago

+1

ruandre commented 9 years ago

:+1:

phpdude commented 9 years ago

+1

technobulka commented 9 years ago

+1

0x646e78 commented 9 years ago

+1

ihnorton commented 9 years ago

:+1:

thorbenegberts commented 9 years ago

:+1:

nickolasclarke commented 9 years ago

+1

YPCrumble commented 9 years ago

+1

kimmobrunfeldt commented 9 years ago

:+1:

tknerr commented 9 years ago

just ran into this too.... :+1: :+1: :+1:

pekeler commented 9 years ago

:+1:

imnithin commented 9 years ago

:+1:

ryanw3b3r commented 9 years ago

Super easy way to track your gist comments is to use https://gistwatch.com Nice setup screen, login with your Github credentials and off you go.

ixley commented 9 years ago

+1 Was really surprised to realize this is not supported in Gists. Seems strange it has been ignored for so long...

melrief commented 9 years ago

+1

bergus commented 9 years ago

:+1:

140am commented 9 years ago

+1

Myoldmopar commented 9 years ago

+1

stefansundin commented 9 years ago

No one wanted to donate towards my donation goal to add secret gist comments to my RSS website, but I just did it anyway. The old unauthenticated route still works for public gists. Check out the update: https://gh-rss.herokuapp.com/

I'd be willing to add email notifications in a similar donation goal, but this is not something I will code on my own because I prefer to get my comments via RSS.

Let me know what you think.

dandv commented 9 years ago

The mere fact that Gistwatch exists shows how miserable the situation is. What is so difficult about implementing notifications for comments on gists, when they work perfectly find on GitHub issues and PRs?

isaacdurazo commented 9 years ago

:+1:

mburgert commented 9 years ago

I wonder if there's an actual business reason GitHub doesn't move on this- a private Gist with comment notifications might somewhat approach a paid feature like a private repo.

dandv commented 9 years ago

I asked support@github.com "Just curious, why is it that comments on gists don't send notifications like comments on GH issues or PRs?" and linked to this thread.

The reply was mostly boilerplate:

Thanks for the suggestion! I can definitely see how it would be useful to receive email notifications for Gist comments. I'll certainly pass it along to the team. I can't promise if/when we might implement that, however your feedback has definitely been recorded.

Let us know if you have any other questions!

140am commented 9 years ago

if there are concerns with spam/abuse of notification queues.. i would be very happy to "just" see this feature on registered/not anonymous gists :bowtie:

SCullman commented 9 years ago

+1

joeguilmette commented 9 years ago

This thread is insane.

louisreingold commented 9 years ago

+1

joost commented 9 years ago

+1

junkblocker commented 9 years ago

:+1:

willwhitney commented 9 years ago

+1

slowkow commented 9 years ago

:+1:

dmitry-lobanov commented 9 years ago

:+1:

JacobBennett commented 9 years ago

http://giscus.co now offers this service for free! Thanks to @mattstauffer and @tightenco

gvaughn commented 9 years ago

:+1:

mattstauffer commented 9 years ago

haha, thanks @JacobBennett, yah, we got DigitalOcean to co-sponsor an app to provide Gist comment notification for free: https://giscus.co

junkblocker commented 9 years ago

Hi @mattstauffer Why does giscus need write permissions to gists to work?

dmtucker commented 9 years ago

:+1: This is very surprising :(

mattstauffer commented 9 years ago

@junkblocker I think there was an issue with not getting access to private gists when we didn't ask for the gist scope, but to be honest I can't remember. Are you a oAuth scope guru? If so, I'd love input.

junkblocker commented 9 years ago

@mattstauffer I am not an oAuth guru but I typically only care for comments on public gists, no? Comments on private gists, assuming the URL is being shared with different people privately, is not my use case at least.

mattstauffer commented 9 years ago

@junkblocker yah, but there are plenty of people who do use it for secret gists. Moving this conversation to an issue on Giscus so everyone else in this thread doesn't keep getting notified of our chat. https://github.com/tightenco/giscus/issues/15

BenMorel commented 9 years ago

:+1:

n8henrie commented 9 years ago

:+1:

solyarisoftware commented 9 years ago

+1

serenanubi commented 9 years ago

:+1:

cecilemuller commented 9 years ago

:+1:

FokkeZB commented 9 years ago

:+1:

dcleao commented 9 years ago

My God, how can this be? :+1:

afrjorge commented 9 years ago

+1

mydoghasworms commented 8 years ago

How can this still be an issue after so long when so many people have raised it? Come on, for goodness' sake! (And thanks for the great service to the community at large, by the way, but please, can we get this working?) :pray: :bow: :metal: