isalin / TBbard

Automated FFXIV Bard Performer (Now with MIDI support!)
MIT License
35 stars 10 forks source link

Issue with held notes, and repeating previous songs. #16

Open PaladinArndt opened 6 years ago

PaladinArndt commented 6 years ago

I have the most recent version, as well as an older version of this program installed, and both seem to be having an issue with notes being held as one very long note when the same note is supposed to be played multiple times in a row. This issue happens when using the full keyboard layout, and making sure that my min FPS value is set accurately. It seems to go away when not using the full keyboard layout.

In addition, I just recently started having an issue where the previous song that I played will try to play over my currently selected song, and will stop if I stop the song and hit play again. This seems more prevalent if I decrease the start time from 3 seconds to any value lower. Was curious if there was a solution, as this issue bothers me a bit more than the held notes issue.

isalin commented 6 years ago

I'll look into it!

I made a preliminary version that should fix the 2 songs playing at once issue (and the play button should also work as a pause button now!). Would you mind checking that it solves the issue?

TBbard_v1.11.zip

The held notes thing is a bit trickier. It happens because ffxiv doesn't get enough time to notice that the key has been let go. The problem is that if TBbard does give it more time, some songs (especially fast paced ones) will start sounding a bit off.

I might end up making a setting for controlling it or something, since mot songs should still sound fine with a couple of milliseconds extra delay here and there.

PaladinArndt commented 6 years ago

That was pretty fast! Thank you- I'll check it out and report back the first chance I get.

PaladinArndt commented 6 years ago

I tested it out for about 3 hours, and didn't have a single instance of two songs playing at the same time, so whatever change you made appears to have fixed that issue.. Pause button also appears to be working correctly, and is very handy.

isalin commented 6 years ago

Great! Thank you for helping out!

Unfortunately, I probably won't have the time to take a look a the held notes thing until next week.