search

italia / spid-cie-oidc-django

The SPID/CIE OIDC Federation SDK, written in Python
Apache License 2.0
27 stars 28 forks source link

[bugifx] substitute pattern delimiter in docker-prepare.sh #242

Closed TakahikoKawasaki closed 1 year ago

TakahikoKawasaki commented 1 year ago

Substitute patterns in docker-prepare.sh use backlashes as delimiters, but the default sed on Mac does not allow backslashes to be used as delimiters and emits the following error logs.

$ ~/GitHub/italia/spid-cie-oidc-django$ which sed
/usr/bin/sed
$ ~/GitHub/italia/spid-cie-oidc-django$ bash docker-prepare.sh 
sed: 1: "s\http://127.0.0.1:8000 ...": substitute pattern can not be delimited by newline or backslash
sed: 1: "s\http://127.0.0.1:8000 ...": substitute pattern can not be delimited by newline or backslash
sed: 1: "s\http://127.0.0.1:8000 ...": substitute pattern can not be delimited by newline or backslash
sed: 1: "s\http://127.0.0.1:8000 ...": substitute pattern can not be delimited by newline or backslash
sed: 1: "s\http://127.0.0.1:8000 ...": substitute pattern can not be delimited by newline or backslash
sed: 1: "s\http://127.0.0.1:8000 ...": substitute pattern can not be delimited by newline or backslash
TakahikoKawasaki commented 1 year ago

Sorry, I close this PR because the main branch is not the right one to which I submit a PR.

peppelinux commented 1 year ago

Dont worry taka, i can rebase It to Dev branch

peppelinux commented 1 year ago

It seems that youre using an old version, please do an update of your project with the last version

Anyway your PR Is not affected by updates, because It touches only the docker scripts