itchannel / fordpass-ha

Fordpass integration for Home Assistant
301 stars 53 forks source link

Window Position always shows as "Open" #56

Closed MartyTremblay closed 3 years ago

MartyTremblay commented 3 years ago

Attributes for all 4 windows show "Fully_closed_position" but entity state shows "Open"

DriverWindowPosition Fully_closed_position
PassWindowPosition Fully_closed_position
RearDriverWindowPos Fully_closed_position
RearPassWindowPos Fully_closed_position

Please refer to my JSON ouput found here https://github.com/itchannel/fordpass-ha/issues/52#issue-756622726

itchannel commented 3 years ago

Thanks looks like your car gives a different window position value that ones I've seen so far so will add in a check for it.

MartyTremblay commented 3 years ago

It's what I've noticed myself. Perhaps a simple Regex will do the trick.

thisisbenwoo commented 3 years ago

BTW, I haven't had a chance to report this, but I have the same issue with my Explorer


BenWoo | +1 (212) 724-1188 | thisisbenwoo@gmail.com

On Fri, Dec 11, 2020 at 6:49 AM Martin Tremblay notifications@github.com wrote:

It's what I've noticed myself. Perhaps a simple Regex will do the trick.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/itchannel/fordpass-ha/issues/56#issuecomment-743235107, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK6CPPLHR3KDNMYJPXBWDXDSUIWN3ANCNFSM4UVM3LSA .

itchannel commented 3 years ago

This should be fixed in #57

itchannel commented 3 years ago

Closing as this issue has been fixed

paulgbrichardson commented 3 years ago

I am still seeing this issue in 1.10

The State is Open but the attributes read as

driverWindowPosition: Fully_Closed passWindowPosition: Fully_Closed rearDriverWindowPos: Fully_Closed rearPassWindowPos: Fully_Closed

MartyTremblay commented 3 years ago

I am still seeing this issue in 1.10

The State is Open but the attributes read as

driverWindowPosition: Fully_Closed passWindowPosition: Fully_Closed rearDriverWindowPos: Fully_Closed rearPassWindowPos: Fully_Closed

I'm seeing the same issue as well.

Banzarykey commented 3 years ago

Still getting this issue.

driverWindowPosition Fully_Closed passWindowPosition Fully_Closed rearDriverWindowPos Fully_Closed rearPassWindowPos Fully_Closed

MartyTremblay commented 3 years ago

Fixed in #62 and released #63

Thanks!