search

itchannel / fordpass-ha

Fordpass integration for Home Assistant
301 stars 53 forks source link

Rear windows report incorrectly #68

Closed jimmychanga closed 3 years ago

jimmychanga commented 3 years ago

Current version: 1.12 2019 Ford Edge ST

DriverWindowPosition Fully_Closed PassWindowPosition Fully_Closed RearDriverWindowPos Undefined RearPassWindowPos Undefined

itchannel commented 3 years ago

Do you have rear windows in your car?

Looking at your car it looks like you do, but probably named something different for your model. Will see if I can make the function more generic going forward

jimmychanga commented 3 years ago

Well yeah, it’s why I’m reporting it :)

It’s a SUV.

Get Outlook for iOShttps://aka.ms/o0ukef

From: itchannel notifications@github.com Sent: Monday, December 28, 2020 6:54:45 PM To: itchannel/fordpass-ha fordpass-ha@noreply.github.com Cc: jimmychanga joemarr_intek@hotmail.com; Author author@noreply.github.com Subject: Re: [itchannel/fordpass-ha] Rear windows report incorrectly (#68)

Do you have rear windows in your car?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/itchannel/fordpass-ha/issues/68#issuecomment-751899410, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AASLOXLDMWREOPOIKXC6QK3SXELELANCNFSM4VLPAD4A.

itchannel commented 3 years ago

Out of interest are they electric windows in the rear of your car? Also are those the only window values you seen when viewing the window entity. As it looks like your car can't give readings for the rear windows. I can add "Undefined" to the filter so they will no longer report as "Open"

jimmychanga commented 3 years ago

Yes, they are electric.

As of the latest version, the front windows report the correct status and the rear windows report undefined.

In the previous version, all 4 windows showed as Open.

Joe Marr C: 704-773-1985 E: joe.marr@bodiddely.commailto:joe.marr@bodiddely.com

From: itchannel notifications@github.com Sent: Tuesday, December 29, 2020 5:31 PM To: itchannel/fordpass-ha fordpass-ha@noreply.github.com Cc: jimmychanga joemarr_intek@hotmail.com; Author author@noreply.github.com Subject: Re: [itchannel/fordpass-ha] Rear windows report incorrectly (#68)

Out of interest are they electric windows in the rear of your car? Also are those the only window values you seen when viewing the window entity. As it looks like your car can't give readings for the rear windows. I can add "Undefined" to the filter so they will no longer report as "Open"

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/itchannel/fordpass-ha/issues/68#issuecomment-752263778, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AASLOXKP6O3BNYG2YGAMJE3SXJKBRANCNFSM4VLPAD4A.

itchannel commented 3 years ago

The previous version didn't take into account the status of "Undefined" where as the new one does. It looks like your rear windows do not support "statuses" on my new pickup it doesn't support window statuses for any windows. The easiest fix is to add "Undefined" to the array so it won't report it as Open anymore for the entire group. It will continue to report Undefined for the individual status but the actual state of the main entity will report "Closed" instead of "open" all th time.

jimmychanga commented 3 years ago

Thats fine, I figured you would want to know. The FordPass app does show correct statuses, so I suspect the issue lies more with Ford's external facing API. Where are you pulling this data from, I can try to troubleshoot the issue myself.

itchannel commented 3 years ago

Interesting as it uses the exact same API the ford app uses. If you have time run the following Debug script which will log to a txt file all the calls. The one your interested in is the last one which contains a big json array of all the statuses. If you can grab out the "WindowPosition" array from that I can check to see how your statuses are different from what I currently grab.

jimmychanga commented 3 years ago

Here ya go:

'windowPosition': { 'driverWindowPosition': { 'value': 'Fully_Closed', 'status': 'CURRENT', 'timestamp': '12-30-2020 00:36:47'}, 'passWindowPosition': { 'value': 'Fully_Closed', 'status': 'CURRENT', 'timestamp': '12-30-2020 00:36:47'}, 'rearDriverWindowPos': { 'value': 'Undefined', 'status': 'CURRENT', 'timestamp': '12-30-2020 00:36:47'}, 'rearPassWindowPos': { 'value': 'Undefined', 'status': 'CURRENT', 'timestamp': '12-30-2020 00:36:47'} }

itchannel commented 3 years ago

So that is exactly what the integration is seeing "Undefined" for 2 of your windows. So your fordpass app either must not show the status of those back 2 windows or it lies and just says "Closed". As the integration and that debug script uses exactly the same API endpoint.

I'll add in so it doesn't show "Undefined" statuses as open and if you ever find those two windows show anything other than "Undefined" later on we can revisit it

jimmychanga commented 3 years ago

Ok, cool. I'll run the debug periodically and let you know if anything changes. In the future, if you need help testing or troubleshooting issues, let me know.

itchannel commented 3 years ago

Closing for now as original issue was fixed and other part wasn't supported.