itsmohit097 / medi-hub

MERN STACK HOSPITAL MANAGEMENT SYSTEM
https://medi--hub.vercel.app/
MIT License
50 stars 100 forks source link

[FEAT] : Adding a loading effect on all doctors page #172

Open Jagpreet153 opened 3 months ago

Jagpreet153 commented 3 months ago

Description

Adding a preloader before loading the page matching the UI of the site

Actual Behavior

The page is blank when the site is loading

Expected Behavior

Until the site is being loaded the user will see the preloader rendering

Kindly assign this task to me under GSSoC'24

itsmohit097 commented 3 months ago

@Jagpreet153 i need a loading on all doctors page (fetched from the db) do u understand the issue? want to work on it?

Jagpreet153 commented 3 months ago

@itsmohit097 Only on all doctors page not on other pages? Sure , I want to work on this issue .

itsmohit097 commented 3 months ago

@Jagpreet153 assigned to u. Yes only use [loader ,setLoader] on docotrs page Only make changes regarding to the issue (no other changes need to made) [Important] : Do not waste your precious time. Kindly do the fork and branch process properly (read contribution.md file) If not followed properly PR will not be merged and the issue will be assigned to another contributor.

nishant0708 commented 3 months ago

Can i work on this issue

itsmohit097 commented 3 months ago

@Jagpreet153 update??

Jagpreet153 commented 3 months ago

@Jagpreet153 update??

@itsmohit097 I will generate PR by today or tomorrow

itsmohit097 commented 3 months ago

@Jagpreet153 i added a Skelton loading effect by fetching the repo u can see the changes If u can improve it do the changes in that

Jagpreet153 commented 3 months ago

Ok @itsmohit097 Kindly add me as assignee to this issue

Jagpreet153 commented 3 months ago

@itsmohit097 Have a look . I have added another animation in the skeleton loading file . If you find it well let me know I will raise PR .

https://github.com/itsmohit097/medi-hub/assets/119691733/f2c33802-6769-4de8-94b1-804a2e3df8a0

itsmohit097 commented 3 months ago

@Jagpreet153 not this animation. add a shimmer effect to it.

Jagpreet153 commented 3 months ago

@itsmohit097 I have added shimmer effect , but I have not fetched doctors data from backend . So I displayed a message instead .

https://github.com/itsmohit097/medi-hub/assets/119691733/a5fd4ad4-a0b3-468a-bb93-3a7925404058

itsmohit097 commented 3 months ago

Fine raise PR now

Jagpreet153 commented 3 months ago

@itsmohit097 please respond to this PR