Cleaning canproco repo and reformating README

ivadomed / canproco

Code for preprocessing the CanProCo brain and spinal cord dataset

MIT License

4 stars 1 forks source link

Cleaning canproco repo and reformating README #80

Closed plbenveniste closed 9 months ago

plbenveniste commented 9 months ago

The goal of this PR is to:

clean the CanProCo repo by removing preprocessing scripts which were used for manual correction of the lesion segmentation
update the main README file to point to each subproject

Resolves: https://github.com/ivadomed/canproco/issues/17, https://github.com/ivadomed/canproco/issues/79

plbenveniste commented 9 months ago

@valosekj Can you review the changes before we tag Julien ? I was thinking maybe about adding a GIF or a figure to the main README.md to make it more attractive. What do you think ?

valosekj commented 9 months ago

@valosekj Can you review the changes before we tag Julien ?

Thank you for cleaning the repo! I added a few suggestions.

I was thinking maybe about adding a GIF or a figure to the main README.md to make it more attractive. What do you think ?

Good idea! Maybe we could also include the official CanProCo logo?

plbenveniste commented 9 months ago

All done on my side @valosekj !

valosekj commented 9 months ago

All done on my side @valosekj !

Thank you for addressing my comments! LGTM now!

One last point-- the logos might be placed next to each other. Also, the GIF seems to me to be "too much wide":

plbenveniste commented 9 months ago

Fixed now ! Ready to review !

plbenveniste commented 9 months ago

Thanks for your feedbacks. Merging the branch now !