search

ivapylibs / Surveillance

The surveillance system for the SuperviseIt project
0 stars 1 forks source link

not a package #2

Closed pv33 closed 3 years ago

pv33 commented 3 years ago

The surveillance repository does not instantiate a package, thus there is no mechanism to add to the known package space. As per #1 the code is most likely being managed within an IDE, which should never be done because it hides the actually dependencies from the programmer and prevents others from successfully reproducing code without knowing how to configure their IDE. What if they are not using an IDE?

It is OK to use one if that's what your skills or comfort level permit, but it is not OK for pushed code to not have been tested using command line. It should always work when operating in the bare minimum environment.

yiyeChen commented 3 years ago

@pv33

As explained in the #1, I don't use IDE and I have run the code from the command line. The bug is caused mainly by my path setting. Anyway it won't happen again.

I can make this repository a package, but before that I do have a question. I thought the creation of a package is for the APIs of a repository to be used by other repositories, whereas I am creating this ivapylibs/Surveillance to be the highest level repository. (e.g Surveillance will needs the classes in the detector so we made the detector as a package, but no repository will needs the Surveillance class as it will run as a stand-alone thread during deployment). In this case do we still need to make the Surveillance a package?