search

iynere / compare-url

CircleCI 2.1 pipelines disable the CIRCLE_COMPARE_URL environment variable, useful when working with monorepo projects. This orb manually recreates (and improves!) it.
https://circleci.com/orbs/registry/orb/iynere/compare-url
32 stars 20 forks source link

feedback from angular folks #15

Open iynere opened 5 years ago

iynere commented 5 years ago

https://github.com/angular/angular/commit/7374dfd1fa7a2c1a42ce8d4078fbe6d70a74fb89

iynere commented 5 years ago
  1. (By looking at the code) it would only work if the rerun workflow is the latest workflow on the branch (which is not guaranteed to be true)
  2. It is less efficient (e.g. makes unnecessary CircleCI API requests for builds on different branches, installs extra dependencies, persists files to the workspace (as a means of passing the result to the calling job), etc.)
    1. It is slightly more complicated to setup and consume than our own script
    2. Its implementation is more complicated than needed for our usecase (e.g. handles different git providers, handles newly created branches, etc.)