iynere / compare-url

CircleCI 2.1 pipelines disable the CIRCLE_COMPARE_URL environment variable, useful when working with monorepo projects. This orb manually recreates (and improves!) it.
https://circleci.com/orbs/registry/orb/iynere/compare-url
32 stars 20 forks source link

Still broken on first build to new branch #25

Open yinzara opened 5 years ago

yinzara commented 5 years ago

Seems the fix to #21 has caused another error:

fatal: Not a valid commit name 29201976786eae7f3a86ed1678b91ef5a62bfc00 unknown return code 128 from git merge-base with base commit 29201976786eae7f3a86ed1678b91ef5a62bfc00, from job 1302

sibelius commented 5 years ago

can you provide your circleci config?

it is working fine in 1.0.2

yinzara commented 5 years ago

My build file is large and complex but this is the relevant parts. I think the issue is because of a rebase where a job's commit is no longer a valid commit as it was rebased and dropped. Maybe a return code of 128 can be treated as a silent failure and allow the scan to occur.

version: 2.1

orbs:
  circle-compare-url: iynere/compare-url@1.0.2

commands:
  checkout-and-yarn:
    steps:
      - checkout
      - circle-compare-url/reconstruct:
          project-path: /build
      ...
jobs:
  build:
    working_directory: /build
    steps:
      - checkout-and-yarn
...
workflows:
  version: 2
  build:
    jobs:
      - build
...

My log outputs something like:

...
checking if feature-compare-orb is a new branch...
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100  5477  100  5477    0     0  92830      0 --:--:-- --:--:-- --:--:-- 92830
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 52414    0 52414    0     0   691k      0 --:--:-- --:--:-- --:--:--  691k
----------------------------------------------------------------------------------------------------
yes, feature-compare-orb is new and bf55d7c7e84a31c428258300508c345ea30dcc2f is its only commit
finding most recent ancestor commit from any other branch...
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 67423    0 67423    0     0   765k      0 --:--:-- --:--:-- --:--:--  765k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 67423    0 67423    0     0   290k      0 --:--:-- --:--:-- --:--:--  290k
----------------------------------------------------------------------------------------------------
commit 2720e1378989940953fcd060e4e080518670c35c from job 1682 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 65487    0 65487    0     0   819k      0 --:--:-- --:--:-- --:--:--  830k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 65487    0 65487    0     0   380k      0 --:--:-- --:--:-- --:--:--  378k
----------------------------------------------------------------------------------------------------
commit b5925b10c82eaed516c21012b7b69a948bc8c0c5 from job 1681 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74995    0 74995    0     0   747k      0 --:--:-- --:--:-- --:--:--  747k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74995    0 74995    0     0   615k      0 --:--:-- --:--:-- --:--:--  615k
----------------------------------------------------------------------------------------------------
commit b5925b10c82eaed516c21012b7b69a948bc8c0c5 from job 1680 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 65751    0 65751    0     0   668k      0 --:--:-- --:--:-- --:--:--  668k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 65751    0 65751    0     0   729k      0 --:--:-- --:--:-- --:--:--  729k
----------------------------------------------------------------------------------------------------
commit 04a66e680cedaf5f1b5353bee9e8eb672de3c26b from job 1679 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 66181    0 66181    0     0   652k      0 --:--:-- --:--:-- --:--:--  652k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 66181    0 66181    0     0   742k      0 --:--:-- --:--:-- --:--:--  742k
----------------------------------------------------------------------------------------------------
commit 04a66e680cedaf5f1b5353bee9e8eb672de3c26b from job 1678 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74004    0 74004    0     0   573k      0 --:--:-- --:--:-- --:--:--  573k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74004    0 74004    0     0   555k      0 --:--:-- --:--:-- --:--:--  555k
----------------------------------------------------------------------------------------------------
commit 04a66e680cedaf5f1b5353bee9e8eb672de3c26b from job 1677 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 63049    0 63049    0     0   603k      0 --:--:-- --:--:-- --:--:--  597k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 63049    0 63049    0     0   699k      0 --:--:-- --:--:-- --:--:--  699k
----------------------------------------------------------------------------------------------------
commit 99c49ccb7dd9e3a76b14a43dc8583107c82f69d6 from job 1676 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 65606    0 65606    0     0   674k      0 --:--:-- --:--:-- --:--:--  674k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 65606    0 65606    0     0   577k      0 --:--:-- --:--:-- --:--:--  577k
----------------------------------------------------------------------------------------------------
commit 23a3da46aa9e021465fa23b8d23aabfad809d3d2 from job 1675 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 64208    0 64208    0     0   746k      0 --:--:-- --:--:-- --:--:--  746k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 64208    0 64208    0     0   597k      0 --:--:-- --:--:-- --:--:--  597k
----------------------------------------------------------------------------------------------------
commit 23a3da46aa9e021465fa23b8d23aabfad809d3d2 from job 1674 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 62355    0 62355    0     0   676k      0 --:--:-- --:--:-- --:--:--  676k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 62355    0 62355    0     0   761k      0 --:--:-- --:--:-- --:--:--  761k
----------------------------------------------------------------------------------------------------
commit 289b0381a02aa12ca4e9f9e08f733b1a1724a756 from job 1673 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 63053    0 63053    0     0   750k      0 --:--:-- --:--:-- --:--:--  750k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 63053    0 63053    0     0   655k      0 --:--:-- --:--:-- --:--:--  655k
----------------------------------------------------------------------------------------------------
commit 050c022af449e9c6fb34dd3fcb23fef368728143 from job 1672 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 65587    0 65587    0     0   547k      0 --:--:-- --:--:-- --:--:--  542k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 65587    0 65587    0     0   736k      0 --:--:-- --:--:-- --:--:--  736k
----------------------------------------------------------------------------------------------------
commit 258afab56b81196503ef79112c6ad8e0e1e5add1 from job 1671 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 63063    0 63063    0     0   676k      0 --:--:-- --:--:-- --:--:--  676k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 63063    0 63063    0     0   592k      0 --:--:-- --:--:-- --:--:--  592k
----------------------------------------------------------------------------------------------------
commit 258afab56b81196503ef79112c6ad8e0e1e5add1 from job 1670 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 62364    0 62364    0     0   346k      0 --:--:-- --:--:-- --:--:--  346k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 62364    0 62364    0     0   790k      0 --:--:-- --:--:-- --:--:--  790k
----------------------------------------------------------------------------------------------------
commit 9cd3c005c636924968452ed11d54ca7c2df0a23f from job 1669 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 62820    0 62820    0     0   697k      0 --:--:-- --:--:-- --:--:--  697k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 62820    0 62820    0     0   807k      0 --:--:-- --:--:-- --:--:--  807k
----------------------------------------------------------------------------------------------------
commit 70f6bb16b4cec65bc466f14e29efb0d5ac71fae4 from job 1668 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 62804    0 62804    0     0   840k      0 --:--:-- --:--:-- --:--:--  840k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 62804    0 62804    0     0   506k      0 --:--:-- --:--:-- --:--:--  506k
----------------------------------------------------------------------------------------------------
commit 6917ad1b14a2335f50ab07b50e9920ea5676cc73 from job 1667 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 65734    0 65734    0     0   605k      0 --:--:-- --:--:-- --:--:--  605k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 65734    0 65734    0     0   568k      0 --:--:-- --:--:-- --:--:--  568k
----------------------------------------------------------------------------------------------------
commit 20e4590cb0b3a07e9923aebeeef4c9e68583f751 from job 1666 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 66180    0 66180    0     0   561k      0 --:--:-- --:--:-- --:--:--  561k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 66180    0 66180    0     0   839k      0 --:--:-- --:--:-- --:--:--  839k
----------------------------------------------------------------------------------------------------
commit 20e4590cb0b3a07e9923aebeeef4c9e68583f751 from job 1665 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74029    0 74029    0     0   463k      0 --:--:-- --:--:-- --:--:--  463k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74029    0 74029    0     0   495k      0 --:--:-- --:--:-- --:--:--  498k
----------------------------------------------------------------------------------------------------
commit 20e4590cb0b3a07e9923aebeeef4c9e68583f751 from job 1664 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 63357    0 63357    0     0   538k      0 --:--:-- --:--:-- --:--:--  538k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 63357    0 63357    0     0   763k      0 --:--:-- --:--:-- --:--:--  754k
----------------------------------------------------------------------------------------------------
commit 3de5cece02ce62d64686d24ccb523e866052e68b from job 1663 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 70204    0 70204    0     0   463k      0 --:--:-- --:--:-- --:--:--  463k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 70204    0 70204    0     0   685k      0 --:--:-- --:--:-- --:--:--  685k
----------------------------------------------------------------------------------------------------
commit f847e5ce46790e2f7202cb608b67b0a1d32d2db8 from job 1662 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 66158  100 66158    0     0   603k      0 --:--:-- --:--:-- --:--:--  603k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 66158    0 66158    0     0   598k      0 --:--:-- --:--:-- --:--:--  598k
----------------------------------------------------------------------------------------------------
commit 3de5cece02ce62d64686d24ccb523e866052e68b from job 1661 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 73997    0 73997    0     0   472k      0 --:--:-- --:--:-- --:--:--  472k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 73997    0 73997    0     0   622k      0 --:--:-- --:--:-- --:--:--  622k
----------------------------------------------------------------------------------------------------
commit 3de5cece02ce62d64686d24ccb523e866052e68b from job 1660 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 65728    0 65728    0     0   746k      0 --:--:-- --:--:-- --:--:--  746k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 65728    0 65728    0     0   682k      0 --:--:-- --:--:-- --:--:--  682k
----------------------------------------------------------------------------------------------------
commit c883fdf9fb966748583285402a4374084d5d4e28 from job 1659 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 66177    0 66177    0     0   212k      0 --:--:-- --:--:-- --:--:--  211k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 66177    0 66177    0     0   652k      0 --:--:-- --:--:-- --:--:--  652k
----------------------------------------------------------------------------------------------------
commit c883fdf9fb966748583285402a4374084d5d4e28 from job 1658 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74019    0 74019    0     0   840k      0 --:--:-- --:--:-- --:--:--  840k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74019    0 74019    0     0   768k      0 --:--:-- --:--:-- --:--:--  768k
----------------------------------------------------------------------------------------------------
commit c883fdf9fb966748583285402a4374084d5d4e28 from job 1657 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 65142    0 65142    0     0   895k      0 --:--:-- --:--:-- --:--:--  895k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 65142    0 65142    0     0   623k      0 --:--:-- --:--:-- --:--:--  623k
----------------------------------------------------------------------------------------------------
commit 6fedab3c13720f5219f2ef87dde642293689e096 from job 1656 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74623    0 74623    0     0   334k      0 --:--:-- --:--:-- --:--:--  332k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74623    0 74623    0     0   818k      0 --:--:-- --:--:-- --:--:--  818k
----------------------------------------------------------------------------------------------------
commit 6fedab3c13720f5219f2ef87dde642293689e096 from job 1655 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 64572    0 64572    0     0   630k      0 --:--:-- --:--:-- --:--:--  630k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 64572    0 64572    0     0   678k      0 --:--:-- --:--:-- --:--:--  678k
----------------------------------------------------------------------------------------------------
commit 1e4c58a493022c0fdb665957212186f3bb981aed from job 1654 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74053    0 74053    0     0   777k      0 --:--:-- --:--:-- --:--:--  777k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74053    0 74053    0     0   592k      0 --:--:-- --:--:-- --:--:--  592k
----------------------------------------------------------------------------------------------------
commit 1e4c58a493022c0fdb665957212186f3bb981aed from job 1653 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 63849    0 63849    0     0   125k      0 --:--:-- --:--:-- --:--:--  125k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 63849    0 63849    0     0   760k      0 --:--:-- --:--:-- --:--:--  769k
----------------------------------------------------------------------------------------------------
commit 0eec3e1bf42005fd6146397cc8442ea7e636d625 from job 1652 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74048    0 74048    0     0   786k      0 --:--:-- --:--:-- --:--:--  786k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74048    0 74048    0     0   520k      0 --:--:-- --:--:-- --:--:--  520k
----------------------------------------------------------------------------------------------------
commit 0eec3e1bf42005fd6146397cc8442ea7e636d625 from job 1651 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 64529    0 64529    0     0   623k      0 --:--:-- --:--:-- --:--:--  623k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 64529    0 64529    0     0   670k      0 --:--:-- --:--:-- --:--:--  677k
----------------------------------------------------------------------------------------------------
commit 0fbcaeb2e8321f1ebcced412da1adf54df4d58e9 from job 1650 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74033    0 74033    0     0   657k      0 --:--:-- --:--:-- --:--:--  657k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74033    0 74033    0     0   587k      0 --:--:-- --:--:-- --:--:--  587k
----------------------------------------------------------------------------------------------------
commit 0fbcaeb2e8321f1ebcced412da1adf54df4d58e9 from job 1649 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 35084  100 35084    0     0   422k      0 --:--:-- --:--:-- --:--:--  422k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 35084  100 35084    0     0   439k      0 --:--:-- --:--:-- --:--:--  433k
----------------------------------------------------------------------------------------------------
commit 20aeb4eb36b0e760e4fd890647c9cdb51c14bd86 from job 1648 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74016    0 74016    0     0   803k      0 --:--:-- --:--:-- --:--:--  803k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74016    0 74016    0     0   926k      0 --:--:-- --:--:-- --:--:--  926k
----------------------------------------------------------------------------------------------------
commit 3c080beab3d8b1cdc7cc6f43d68b9a53bf11399d from job 1647 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 62895    0 62895    0     0   511k      0 --:--:-- --:--:-- --:--:--  511k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 62895    0 62895    0     0   722k      0 --:--:-- --:--:-- --:--:--  722k
----------------------------------------------------------------------------------------------------
commit 45044149647a06ac09d3d64a7cee10a9b365f566 from job 1646 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 34675    0 34675    0     0   423k      0 --:--:-- --:--:-- --:--:--  423k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 34675  100 34675    0     0   423k      0 --:--:-- --:--:-- --:--:--  423k
----------------------------------------------------------------------------------------------------
commit 921667afbd14add1a631be6ac308e8314c6cd256 from job 1645 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 66205    0 66205    0     0   226k      0 --:--:-- --:--:-- --:--:--  227k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 66205    0 66205    0     0   659k      0 --:--:-- --:--:-- --:--:--  659k
----------------------------------------------------------------------------------------------------
commit 921667afbd14add1a631be6ac308e8314c6cd256 from job 1644 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74020    0 74020    0     0   569k      0 --:--:-- --:--:-- --:--:--  564k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74020    0 74020    0     0   675k      0 --:--:-- --:--:-- --:--:--  675k
----------------------------------------------------------------------------------------------------
commit 921667afbd14add1a631be6ac308e8314c6cd256 from job 1643 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 64937    0 64937    0     0   615k      0 --:--:-- --:--:-- --:--:--  615k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 64937    0 64937    0     0   689k      0 --:--:-- --:--:-- --:--:--  696k
----------------------------------------------------------------------------------------------------
commit e3423e0f430b4d1e419d7659c4e3eacdd0b03aba from job 1642 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 67026    0 67026    0     0   962k      0 --:--:-- --:--:-- --:--:--  962k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 67026    0 67026    0     0   872k      0 --:--:-- --:--:-- --:--:--  872k
----------------------------------------------------------------------------------------------------
commit e3423e0f430b4d1e419d7659c4e3eacdd0b03aba from job 1641 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74870    0 74870    0     0   803k      0 --:--:-- --:--:-- --:--:--  803k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74870    0 74870    0     0   777k      0 --:--:-- --:--:-- --:--:--  777k
----------------------------------------------------------------------------------------------------
commit e3423e0f430b4d1e419d7659c4e3eacdd0b03aba from job 1640 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 64545    0 64545    0     0   504k      0 --:--:-- --:--:-- --:--:--  504k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 64545    0 64545    0     0   716k      0 --:--:-- --:--:-- --:--:--  708k
----------------------------------------------------------------------------------------------------
commit b6dad36717535a5b7df057c27785ec72acc60551 from job 1639 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 33141  100 33141    0     0   431k      0 --:--:-- --:--:-- --:--:--  431k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 33141  100 33141    0     0   505k      0 --:--:-- --:--:-- --:--:--  505k
----------------------------------------------------------------------------------------------------
commit 7a8bfb34c25fa625179509b9f1a1177a774141ac from job 1638 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74464    0 74464    0     0   501k      0 --:--:-- --:--:-- --:--:--  501k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74464    0 74464    0     0   845k      0 --:--:-- --:--:-- --:--:--  845k
----------------------------------------------------------------------------------------------------
commit b6dad36717535a5b7df057c27785ec72acc60551 from job 1637 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 62911    0 62911    0     0   722k      0 --:--:-- --:--:-- --:--:--  722k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 62911    0 62911    0     0   749k      0 --:--:-- --:--:-- --:--:--  749k
----------------------------------------------------------------------------------------------------
commit f47e1fd2d899a3b7de51986422c6319ae964f95b from job 1636 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 65771    0 65771    0     0   764k      0 --:--:-- --:--:-- --:--:--  764k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 65771    0 65771    0     0   676k      0 --:--:-- --:--:-- --:--:--  676k
----------------------------------------------------------------------------------------------------
commit ee9f66f641568a1363644757250cd5ad4ff08128 from job 1635 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 66198    0 66198    0     0   567k      0 --:--:-- --:--:-- --:--:--  567k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 66198    0 66198    0     0   598k      0 --:--:-- --:--:-- --:--:--  593k
----------------------------------------------------------------------------------------------------
commit ee9f66f641568a1363644757250cd5ad4ff08128 from job 1634 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74042    0 74042    0     0   478k      0 --:--:-- --:--:-- --:--:--  478k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74042    0 74042    0     0   663k      0 --:--:-- --:--:-- --:--:--  663k
----------------------------------------------------------------------------------------------------
commit ee9f66f641568a1363644757250cd5ad4ff08128 from job 1633 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 63414    0 63414    0     0   573k      0 --:--:-- --:--:-- --:--:--  573k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 63414    0 63414    0     0   638k      0 --:--:-- --:--:-- --:--:--  638k
----------------------------------------------------------------------------------------------------
commit 316b11b99d94c837bfa885c255675f6d8e9c1856 from job 1632 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 57840    0 57840    0     0   724k      0 --:--:-- --:--:-- --:--:--  724k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 57840    0 57840    0     0   613k      0 --:--:-- --:--:-- --:--:--  613k
----------------------------------------------------------------------------------------------------
commit ee9f66f641568a1363644757250cd5ad4ff08128 from job 1631 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 66200    0 66200    0     0   646k      0 --:--:-- --:--:-- --:--:--  653k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 66200    0 66200    0     0   751k      0 --:--:-- --:--:-- --:--:--  751k
----------------------------------------------------------------------------------------------------
commit 316b11b99d94c837bfa885c255675f6d8e9c1856 from job 1630 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74043    0 74043    0     0   597k      0 --:--:-- --:--:-- --:--:--  592k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 74043    0 74043    0     0   730k      0 --:--:-- --:--:-- --:--:--  730k
----------------------------------------------------------------------------------------------------
commit 316b11b99d94c837bfa885c255675f6d8e9c1856 from job 1629 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 68043    0 68043    0     0   604k      0 --:--:-- --:--:-- --:--:--  609k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 68043    0 68043    0     0   699k      0 --:--:-- --:--:-- --:--:--  706k
----------------------------------------------------------------------------------------------------
commit 373a2ac941109d5df17b9b54e0165f8c3da49fb5 from job 1628 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 77545    0 77545    0     0   582k      0 --:--:-- --:--:-- --:--:--  587k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 77545    0 77545    0     0   728k      0 --:--:-- --:--:-- --:--:--  728k
----------------------------------------------------------------------------------------------------
commit 373a2ac941109d5df17b9b54e0165f8c3da49fb5 from job 1627 is not an ancestor of the current commit
----------------------------------------------------------------------------------------------------
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 64124    0 64124    0     0   517k      0 --:--:-- --:--:-- --:--:--  517k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

100 64124    0 64124    0     0   754k      0 --:--:-- --:--:-- --:--:--  754k
fatal: Not a valid commit name c86190cf2b5f461c6f845d33b78d19bbbac49a60
unknown return code 128 from git merge-base with base commit c86190cf2b5f461c6f845d33b78d19bbbac49a60, from job 1626
Exited with code 1
sibelius commented 5 years ago

it could be related to this one https://github.com/iynere/compare-url/issues/28

Fumler commented 5 years ago

We are also still experiencing this issue. (Using 1.0.0 of the orb, though)

If it helps debug, here is the relevant config:

jobs:
  build:
    <<: *js_defaults
    steps:
      - checkout
      - compare-url/reconstruct:
          project-path: ~/app
      - restore_cache: *restore-yarn-cache
      - run: "yarn --frozen-lockfile --production=false --prefer-offline"
      - save_cache: *save-yarn-cache
      - run:
          name: "Build all changed packages."
          command: |
            echo "Requires each package to have a build command in the root package.json in the format of build:PACKAGE_NAME. E.g. build:main"

            CIRCLE_COMPARE_URL=$(cat CIRCLE_COMPARE_URL.txt)
            COMMIT_RANGE=$(echo $CIRCLE_COMPARE_URL | sed 's:^.*/compare/::g')
            echo "Commit range: $COMMIT_RANGE"

            for package in $(cat packages/deployable-packages.txt packages/serverless-js.txt); do
             if [ -n "$(git diff $COMMIT_RANGE --name-status -- packages/$package)" ]; then
                echo "Building ${package}"
                NODE_ENV="production" yarn build:$package
              else
                echo "${package} not modified; no need to build"
              fi
            done

            echo "Pruning node_modules"
            chmod +x ./.circleci/scripts/node-prune
            ./.circleci/scripts/node-prune

            echo "Persisting to workspace:"

      - persist_to_workspace:
          root: ~/
          paths:
            - app

with a spam of

commit some-hash from job some-job is not an ancestor of the current commit

and then

fatal: Not a valid commit name 2dc88d93d9a88799dcbbcea5cb5de364bd9ba4fd
unknown return code 128 from git merge-base with base commit 2dc88d93d9a88799dcbbcea5cb5de364bd9ba4fd, from job 57845
Exited with code 1

Unfortunately this is a private repo so you can't explore the commits, but this is a simple PR created by dependabot, which just changes our package.json and yarn.lock files.

PR comparing from a new branch with one commit, to master.

Doing a second commit would fix the issue.

emmenko commented 5 years ago

Is someone looking into this problem?

mernst commented 5 years ago

I am encountering this problem as well. I am using version 1.2.0 of the orb.

My config.yml file: https://github.com/mernst/randoop/blob/circleci-test-requireJavadoc-2-orb-for-bug-report/.circleci/config.yml

The build: https://circleci.com/gh/mernst/randoop/92

The build fails with

fatal: Not a valid commit name 8a4dec70083318018320660b523b978efc8b19db
unknown return code 128 from git merge-base with base commit 8a4dec70083318018320660b523b978efc8b19db, from job 90

Everything is open source, so I hope this will permit this bug to be investigated and resolved. Do you need any other information from me to help?

Also, is there any workaround? I would prefer my build to proceed, with the environment variables not set, rather than the build to fail.

jpaskhay commented 4 years ago

We're running into this issue as well. I've submitted a PR for what I believe should fix the bug.

The RETURN_CODE gets set to 1 while looping over jobs with non-ancestor commits, but never gets cleared/set properly when the git merge-base command returns successfully (since the "or" logic doesn't execute). So it was never executing the branch that handles where the ancestor is actually found.