search

iynere / compare-url

CircleCI 2.1 pipelines disable the CIRCLE_COMPARE_URL environment variable, useful when working with monorepo projects. This orb manually recreates (and improves!) it.
https://circleci.com/orbs/registry/orb/iynere/compare-url
32 stars 20 forks source link

reconstruct command has `when: always`? #31

Closed jrnail23 closed 5 years ago

jrnail23 commented 5 years ago

Orb version

v1.1.0

What happened

Hi @iynere, when using this orb, I had a hell of a time figuring out why my job wasn't stopping when a validation step was failing before the reconstruct command started... I didn't realize that reconstruct has when: always. Is there a way to override that behavior? There's a lot going on in reconstruct, and when it fails, there's a lot of console noise, making it easy to miss any preceding failures (which is what bit me). It just doesn't seem like the kind of command that adds value after a failing step. Your thoughts?

Expected behavior

I'd prefer if the command's when attribute to be parameterized.

iynere commented 5 years ago

that's a reasonable request @jrnail23 wanna PR it ? should be a super easy change. thank you !

jrnail23 commented 5 years ago

@iynere -- just a gentle nudge: my PR is available for your review (#32)

iynere commented 5 years ago

ah, thank you ! @jrnail23 apologies, will 👀 today

iynere commented 5 years ago

merged ! @jrnail23