Add `shell-options` parameter to `use`

iynere / compare-url

CircleCI 2.1 pipelines disable the CIRCLE_COMPARE_URL environment variable, useful when working with monorepo projects. This orb manually recreates (and improves!) it.

https://circleci.com/orbs/registry/orb/iynere/compare-url

32 stars 20 forks source link

Add `shell-options` parameter to `use` #33

Open sugarshin opened 5 years ago

sugarshin commented 5 years ago

Hi, I added shell-options parameter. please review 🙏

Checklist

[x] All new jobs, commands, executors, parameters have descriptions
[x] Examples have been added for any significant new features
[x] README has been updated, if necessary

Motivation, issues

Useful to be able to select shell options when running custom-logic.

Description

I added shell-options parameter to use. Default is /bin/bash -eo pipefail.

xdays commented 5 years ago

@jpaskhay this PR will break yours, pipefail is set by default. my #39 can avoid it.

jpaskhay commented 5 years ago

@xdays these changes are part of the use command whereas the ancestor logic fix is in the reconstruct command. I believe those execute in separate subshells. I'm honestly good with either of our approaches to the fix, but I think technically this shouldn't cause conflicts

jpaskhay commented 5 years ago

Ultimately I think it should be up to the maintainer(s). Some of the other issues in the repo may lead to larger refractors that may make both of our patches moot anyway :)