Project feedback

[lima1756]

Hey Izu! Loved this project, the UI is delightful and having the video to present it was also great! Overall it was a great work, and I have to admit being surprised when I saw that the site was constructed with plain HTML+JS instead of React, congratulations!

Besides what @azhiah already mentioned, I have some feedback for you:

Fundamentals

• As a good practice if we know a variable is not going to be modified any more, we declare it as const, this way we could avoid mistakes in the future
• I see in some places you used document.querySelector and used a class name for them, just for simplicity and readability if it's going to be only one class name that you are looking for you can always use document.getElementsByClassName

Easy to Understand/Clean Code

• The overall format of your code is great, but one reccomendation I have is to run a formatter in your code so nothing is overlooked, in vs code this can be achieved with "⇧⌥F" you can read more in: https://code.visualstudio.com/docs/editor/codebasics#_formatting
• Something that is difficult I think for everyone is how to format code that is a string within something else (like: https://github.com/izuchukwumba/site-unit2-project1-music-playlist-explorer-starter/blob/main/music-playlist-creator/script.js#L12), and overall you did a great job as most of it is understandable, just as a recommendation if you ever need something similar in the future you can write it in its own file (temporary) and use a formatter and after that paste it where needed!
• I see that you used some destructuring assignment to name things that are grouped together (https://github.com/izuchukwumba/site-unit2-project1-music-playlist-explorer-starter/blob/main/music-playlist-creator/script.js#L242) as useful as this is, my personal opinion this lines are a little too long, so don't be afraid of making multiple lines!

Modularity

• If you ever found yourself writing a manual list of things, example:

let object1 = 1; 
let object2 = 2;
let object3 = 3;

you can always transform that into a list of objects let objects = [1, 2, 3]

extra Some stuff that might be interesting to learn and you could use later if needed/wanted

• When using images in web, to improve accessibility about images for screen readers you can use the alt attribute

[izuchukwumba]

Thanks alot. I will implement these feedbacks in future projects.