search

j2labs / listsurf

Simple website implemented in Brubeck
62 stars 11 forks source link

Hardcoded paths #1

Closed st0w closed 13 years ago

st0w commented 13 years ago

Since path information for login_url is specified in the app config in listsurf.py, it would make sense to use self.application.login_url in places where the URL needs to be referenced, as opposed to the current hardcoded values.

At least one example is in handlers.AccountLogoutHandler.get().

It also might make sense to define a home page/path in the app config that can be referenced after login, so there is some control at the application level, rather than down in the code for handlers.AccountLoginHandler.post()

Minor issues, really.

j2labs commented 13 years ago

I think this is totally on point. The example projects should attempt to demonstrate not only A way to get something down but also THE way to do it.

Pedantic antics are not only approved of, they're encouraged!

j2labs commented 13 years ago

This is fixed now. Thanks dude.