j3k0 / ganomede-chat

Ganomede multi-rooms chat service
0 stars 0 forks source link

Add messageArgsTypes to notification #11

Closed j3k0 closed 7 years ago

j3k0 commented 7 years ago

Similar to what has been done for ganomede-turngame already: https://github.com/j3k0/ganomede-turngame/commit/879fe292e54f3923b5928a56cbf697fd682ce169

Set the field containing the username to type directory:name

elmigranto commented 7 years ago

Looks like .push is pulled as is from req.body. The other thing is system messages, but those do the same except username is $$ and type is event.

Maybe this one should be on clientside?

j3k0 commented 7 years ago

Oh, that's right. Seems like I went for something quick and dirty... So we can close this, I'll fix client side.