search

j9brown / victron-hacs

Home Assistant plug-in for Victron Instant Readout compatible devices
13 stars 4 forks source link

Upgrade to victron-ble 0.8.2 #2

Closed kroese closed 3 months ago

kroese commented 3 months ago

A lot of changes were made to victron-ble that I really want to try out, so could a new version of victron-ble be released (0.8.2) and this repo be updated to point to that new release?

j9brown commented 3 months ago

This is already done. Current version of victron-ble is 0.8.4.

kroese commented 3 months ago

When I look in the manifest.json inside this repo it says 

"requirements": ["git+https://github.com/j9brown/victron-ble.git@main#victron_ble==0.8.1"]
j9brown commented 3 months ago

That’s odd. Are you sure you’re looking at the correct file?

https://github.com/j9brown/victron-hacs/blob/main/custom_components/victron_ble/manifest.json

kroese commented 3 months ago

Nevermind. What I did every time was to search for the string victron-ble in this repo.

But I forgot that the search function of Github shows files how they looked when they were last indexed (which can be a few revisions ago for unpopular repos). So it showed me the old file.

j9brown commented 3 months ago

No worries. I suspect you’ll be wanting the new Smart Lithium and Smart Protect support in which case some changes need to be made to this project to map the data as Home Assistant sensors which I haven’t done. Feel free to give it a shot! (I wish it weren’t quite so tedious to do.)