jackun / VLCTube

The Unlicense
15 stars 4 forks source link

Playback stops after every video in playlists (Chrome/Tampermonkey) #1

Closed ghost closed 10 years ago

ghost commented 10 years ago

I'm not sure if it's even supposed to continue the playlist, but it's been bugging me for a while now.

jackun commented 10 years ago

window.spf is null in tampermonkey, hmm.

ghost commented 10 years ago

Same problem with Greasemonkey on Firefox. I'm on Windows 7.

I'm not very experienced with JS so I probably wouldn't be much of a help.

jackun commented 10 years ago

Try now v43.8. Might need to click playlist Autoplay button few times so vlctube internal state and youtube javascript match :P

ghost commented 10 years ago

It still won't continue with the next video. Tried both Tampermonkey and Greasemonkey. I reinstalled VLCTube and cleared the cache. I also tried clicking the Autoplay buttons and using different settings.

jackun commented 10 years ago

Hm, on linux and on windows FF 26, GM 1.13, VLC 2.1.2 works for me. But if your willing to mess with logs: In Firefox ctrl+shift+J, make sure JS button is selected and look if there is any errors with 25318.user.js In Chrome should be too ctrl+shift+J and select Console tab.

ghost commented 10 years ago

I tried that console tab on Chrome and noticed that there are different errors popping up with different playlists. But it won't work on either of them. May I try one of the playlists you were testing on?

Same versions for me. I don't really get why it doesn't work here.. Maybe it's my location? Differences on Youtube between different countries? Anyway, I tried these playlists:

Playlist 1 (HTML5 libs?): http://www.youtube.com/watch?v=6kOmnN3OLPc&feature=share&list=PLzWYwIASh8HsyB9r-TZWiDHkdnjh4Gswm&index=19 image (The last error there popped up every 250ms, hence it's over 1000)

Playlist 2 (Flash libs?): http://www.youtube.com/watch?v=Rrm4isCQDkQ&feature=share&list=UUBJycsmduvYEL83R_U4JriQ&index=1 EDIT: No errors caused by VLCTube on this one. Stupid youtube ads.

jackun commented 10 years ago

Yeah, these errors shouldn't be a problem (maybe the spf-... though???).

If Youtube's html is still the same and this pasted to the console box with '>'

document.querySelector('li[data-index="2"] ~ li a')

or some other number besides 2 or

document.querySelector('#watch7-playlist-tray li a')

returns something and there is a DIV in html with id 'watch7-playlist-bar-shuffle-button' then it should work.

The logic that does the playlist advancement starts from here if you're willing to dabble some more in code :P https://github.com/jackun/VLCTube/blob/master/25318.user.js#L1832

ghost commented 10 years ago

I'll try that later. It's almost 3 am. :p

ghost commented 10 years ago

It works now. Stupid me, didn't check the Autoplay button on top of the video. I didn't even know there was one, lol. VLCTube runs flawlessly. Good work jackun ;)

Out of curiosity: Is there a way to bind a different audio source to a video with the vlc plugin? Formats over 720p seem to have separated audio. Seems like a download prevention by Google. In VLC the option is called input-slave.

Would be a huge plus if there was an option in VLCTube to enable mixed formats over 720p.

jackun commented 10 years ago

In theory yes, but not every options has been marked as safe for use with plugin, like input-slave. If it can't be exploited (much) and someone submits a patch to enable it then VLC devs might add it.

jackun commented 10 years ago

Well, it was actually broken for Chrom-(e/ium). Closing as fixed for now then.