search

jackun / VLCTube

The Unlicense
15 stars 4 forks source link

VLCTube.toSource() drops Chrome-compatibility #17

Closed nucular closed 9 years ago

nucular commented 9 years ago

injectScript("var VLCinstance = " +VLCTube.toSource() + "();"); at line 4390 ends up in var VLCinstance = JSON.parse(unescape('undefined'))(); since toSource is not available in V8.

Windows 7, 32bit Chrome 36.0.1985.125 m Tampermonkey 3.8.52 VLC 2.1.5 Rincewind

jackun commented 9 years ago

Does v36 even have a NPAPI support now as Chromium doesn't seem to?

nucular commented 9 years ago

EDIT: No, no it doesn't.

Sonic0170 commented 9 years ago

it seems firefox will be the final browser to have NPAPI support but only when clicked to play/use all the browsers seem to be moving in the direction of webGL based plugins or something like that. this makes me think that one day VLC might discontinue the NPAPI plugin and cause this script to be worthless, but i also assume they won't drop it until firefox does also. so far videolan isnt working on a webgl based plugin as of yet.