search

jackun / VLCTube

The Unlicense
15 stars 4 forks source link

Watch Later button not working with multiple Channels #21

Closed LL25255252 closed 9 years ago

LL25255252 commented 10 years ago

VLCtube's Watch Later button stopped working (I can't remember when it started to happen).

Tested in a fresh/new Firefox profile.

VLCtube 57.13 VLC plugin 2.1.0.0 GM 2.2 FF 32.0.1 Win7 64bit

TIA.

jackun commented 10 years ago

Still broken? Works for me so far.

LL25255252 commented 9 years ago

ok...I found the problem.

A year ago, when google intergrated its google plus comments system to youtube, they've asked if I want to change my username to my google plus real name (kind of "merge"). I declined and stayed with my old username.

I now found out that when clicking on "watch later" button VLCtube added the video to my GP (google plus) youtube channel which exists but I don't use and not to my youtube "default" channel.

Disabling VLCtube works OK. I also rechecked it in a fresh FF profile. I have another gmail account with a GP profile which I did "connect" a year ago to my youtube ols account. In this account VLCtube works correctly.

Related - https://support.google.com/youtube/answer/6019090?hl=en

Tested again on VLCtube 57.16

jackun commented 9 years ago

If you use flash, F12 to open the developer (or whatever) bar, switch to Network tab, what does flash send to YT (like extra user id params etc) when you click 'Watch later'?

Currently VLCTube uses logged-in user's session (aka cookies): 1.) gets ajax token from .../token_ajax?action_get_wl_token=1 2.) post video id to .../addto_ajax?action_add_to_watch_later_list=1&feature=player_embedded

If i remember correctly, embedded player uses that api while main player did something a bit different.

LL25255252 commented 9 years ago

I hope that helps (taken from Network). ...snip...

jackun commented 9 years ago

You may want to re-login to youtube ;)

Looks the same. Maybe flash player messes with cookies, hmm.

LL25255252 commented 9 years ago

First, many thanks for looking into this issue.

Is this a difficult issue for you to fix ? If so, do you have an estimate for it to be fixed ? Is there some kind of a workaround for me to use until then or just don't use the button and create a list of those videos using the browsers bookmarks or some kind of other "Read/Watch It Later" services ?

jackun commented 9 years ago

Is this a difficult issue for you to fix ?

I can't say.

But does it show multiple 'channels' when you click the icon in top-right and your 'default' is actually the selected one? blergh... https://support.google.com/youtube/answer/3046356?hl=en

Also https://support.google.com/youtube/answer/2657858?hl=en

LL25255252 commented 9 years ago

Thanks for posting these 2 links.

Let me reassure you. I removed ALL my cookies, cleared the cache and restarted Firefox. Signed in to my google account. Opened yourube.com and I'm automatically signed-in with my regular default old youtube username (I know that that by my avatar and also by clicking the icon in top-right as you mentioned). Below that appears my google plus profile picture.

Lastly, let me remind you that as I stated in my first post - when loading the page without VLCtube the "watch later" button works fine on both "channels".

LL25255252 commented 9 years ago

VLC options > "Always show watch Later Button" . It seems this checkbox is affecting the "watch" pages and not the embedded pages. Can you make it affect also the embedded ones ?

This is especially important for me b/c I got used to click this button many times but since it turned out it's not working for me (see this thread) I need to stop the "habit" of clicking it.

P.S. Maybe until the more-than-one-channel-per-account "watch-later" button issue is resolved you should warn the user that the video may be added to the "watch later" list of one of his other channels or just detect users with accounts like mine and block the action with a message like "Sorry...VLCtube can't as of now perform this action on 'multi-channel' accounts"

TIA.

jackun commented 9 years ago

Yeah, it just currently greasemonkey just uses the active cookies and there's no difference in API use. So logically it should send to currently active account. Damn G+ clusterfuck. But the accounts info should be somewhere as flash works and there is an account selector on YT :-/

LL25255252 commented 9 years ago

@jackun ,Bumping my previous comment (3 weeks have passed so maybe you forgot about it) - https://github.com/jackun/VLCTube/issues/21#issuecomment-59490005 It's a small VLCtube bug (not related to the main "issue"). TIA.

jackun commented 9 years ago

Even though when using different simultaneously logged in accounts, "Watch Later" seemed to work for me even before. Try the 57.34 build and see if setting "authuser" parameter makes any difference.

LL25255252 commented 9 years ago

First, many thanks for still trying to fix this issue.

Installing 57.34 didn't help.

Even though when using different simultaneously logged in accounts, "Watch Later" seemed to work for me even before. The problem happens when using multiple channels not multiple accounts. Is it working for you with multiple channels ?

Do you get the popup to choose a channel when you sign: https://support.google.com/youtube/answer/6019090?hl=en

Finally, I understand that you focus mainly on this "main issue" of "watch later" button and I also don't want to sound "nagging" but have you noticed the small bug I've reported about on my https://github.com/jackun/VLCTube/issues/21#issuecomment-59490005 ?

TIA.

jackun commented 9 years ago

Sometimes creating a test account is helpful and obvious, lol. Ok, "now is work good"?

There's was a difference, a "channel" added "pageid" parameter but plain account didn't, heh

(E: Unrelated, GM doesn't seem to pass on cookies. edit edit: document.cookie doesn't have LOGIN_INFO while injecting GM_xmlhttprequest does.............. idonteven/odd).

LL25255252 commented 9 years ago

Wow, you finally "nailed it" !! The bug is fixed. Many thanks :)

And another nagging reminder so that after you close this thread we can "forget about it" : please fix the small bug I've reported on https://github.com/jackun/VLCTube/issues/21#issuecomment-59490005

jackun commented 9 years ago

"It's not a bug, it's a feature!" Point was to make WL optional for "watch" pages as they have the "Add to" button already. But could add another option to hide WL button.

LL25255252 commented 9 years ago

Okay, sorry..., I missed the point of this checkbox. i guess you added this feature before you introduced the icon-buttons and because the "watch later" button is the widest text-button. So now if someone don't have a wide screen he can use the icon-buttons and this checkbox becomes less important.

But could add another option to hide WL button.

I suggest you shouldn't apply the "hiding" to embedded videos**. Otherwise users might tick (enable) the "Hide 'Watch Later' button" checkbox forgetting that in embedded videos pages there's no alternative "add to" button. The wording in that case will be something like "Hide Watch Later on non-embedded videos".