jackun / VLCTube

The Unlicense
15 stars 4 forks source link

Option to show in fullwindow or fullscreen mode by default #22

Open tophf opened 9 years ago

tophf commented 9 years ago

It would be an awesome feature to show just the video, filling up the window fully, when a youtube video link is opened and playback autostarts. YoutubeCenter offers such mode and it's really handy.

With VLCTube currently I can only fake this behavior by forcing 100% dimensions via CSS and painting the occupied space in black:

.site-center-aligned #player.watch-medium, #player-api-vlc, #movie_player {
    width: 100% !important;
    height: 100vh !important;
}
.site-center-aligned #player.watch-medium {
    top: -48px;
    position: relative;
    z-index: 10000000000;
}
#mymovie-holder {
    height: calc(100vh - 30px) !important;
}
.vlc-scrollbar {
    border: none;
}
body#body, #content, #watch7-content, #mymovie-holder, #theater-background {
    background: black !important;
    background-color: black !important;
    background-image: none !important;
}

Fullscreen autoplay could be useful as well because it's a common feature in video players, although I'm not sure it's possible to implement.

jackun commented 9 years ago

Something like #popup but comments etc intact?

tophf commented 9 years ago

Well, here's a screenshot of the fullwindow mode in YTCenter: fullwindow

There are no scrollbars, no margins - just the video is shown. And when I scroll down it instantly restores a usual youtube video page layout. And when I scroll up to the top again it switches to the fullwindow mode.

My current CSS hack above leaves the vertical scrollbar. fullwindowvlctube Maybe #popup won't? Although it's not a big issue if there'll be no other way around with the VLC plugin.

Sonic0170 commented 9 years ago

im begging you for this jackun, its the only reason im still using 57.24 and even made a backup by forking it, please make this happen ^.^ a simple FullWindow mode/option with all the youtube page layout present below and the scroll bar on the right side would work perfectly fine, i use the "youtube high definition" add-on to force nearly the same exact effect which stopped working after VLCTube v57.24, thus my backup.

its also curious why i never noticed this enhancement request for so long O.o

Sonic0170 commented 9 years ago

with your newest test script you showed me @jackun i think this feature may not be needed