search

jackun / VLCTube

The Unlicense
15 stars 4 forks source link

(solved) a small suggestion - exclude YT's search results page #33

Closed LL25255252 closed 9 years ago

LL25255252 commented 9 years ago

exclude - http://www.youtube.com/results I know I can add it manually through the userscripts > VLCtube > Options but it would be better if it's added "built in" to the script's code.

jackun commented 9 years ago

No can do with SPF. What's the problem?

(I updated the "view other videos" script for myself. It disabled SPF before.)

LL25255252 commented 9 years ago

No can do with SPF. What's the problem? (I updated the "view other videos" script for myself. It disabled SPF before.)

@jackun , I think by mistake you posted your last comment here instead of #31.

jackun commented 9 years ago

No, with SPF player gets loaded and set "offscreen" by css. If you disable it on search page then player isn't loaded on "watch" page either.

LL25255252 commented 9 years ago

I added - http://www.youtube.com/results - to the excluded pages yesterday and since then everything seems to still work fine (clicking videos from the search results page open the watch page and play correctly).

So can you please give me the "steps to reproduce" the problem you talked about in your previous post ?

jackun commented 9 years ago

Well, if you have the "View Youtube videos by same user" script, disable it. Check that SPF works (red loading bar), search for something and reload the search page, click on video link.

LL25255252 commented 9 years ago

First, sorry for returning to this thread after more than 3 months...and thanks for giving me the "steps to reproduce" so I can understand this SPF thing. I followed this STR and now I understand why VLCtube should not be excluded from YT's search results page. Many thank also for uploading here your SPF fix for "View Youtube videos by same user" script. After I installed it SPF started to work again (I'm seeing the read bar).

Did you make your fix/changes onto the script's v1.4.4 2014-07-13 or onto v1.4.3 2014-05-14 ? Is it OK with you that I suggest your version to the original dev of the script ? https://greasyfork.org/en/scripts/946-view-youtube-videos-by-same-user

jackun commented 9 years ago

Well, he's more than welcome to take a look ;) I think it mostly works.

LL25255252 commented 9 years ago

Did you make your fix/changes onto the script's v1.4.4 2014-07-13 or onto v1.4.3 2014-05-14 ?

jackun commented 9 years ago

Looks like v1.4.4

LL25255252 commented 9 years ago

I've just posted about your "View Youtube videos by same user" without disabling SPF version on the the script's page at greasyfork.org https://greasyfork.org/en/forum/discussion/3203/suggestion-a-link-to-a-version-which-doesn-t-disable-spf

I think that you can finally close this thread/issue and thanks again.