jackun / VLCTube

The Unlicense
16 stars 4 forks source link

Request - center the subtitles #42

Closed LL25255252 closed 9 years ago

LL25255252 commented 9 years ago

The subs (closed captions) are now aligned to the left. Can you please center them ?

A video foe example: https://www.youtube.com/watch?v=yNe_HdayTtY TIA

Sonic0170 commented 9 years ago

i can confirm the aligned left subtitles, doesn't seem like too much of an issue, but i guess some people would find it annoying

LL25255252 commented 9 years ago

Here's another one (aligned to the left): https://www.youtube.com/watch?v=y6Sxv-sUYtM

jackun commented 9 years ago

Last time I messed with subtitles I couldn't get it to respect the automagical alignment parameter so the only safe option was to align it to left with absolute position and hope the text fits on display.

Edit: so it needs to be a string like "BOTTOM" instead the integer like 8, heh.

Sonic0170 commented 9 years ago

it does fit properly

jackun commented 9 years ago

v60 works for me now :P Reopen if it's wonky for you [the reader]. Also added simple-ish color picker. jscolor seemed too big to integrate into this (30kb)

LL25255252 commented 9 years ago

First, many thanks for adding the center/align menu.

Sorry that I only tested on one video but I had a Firefox freeze https://www.youtube.com/watch?v=yNe_HdayTtY It happened somewhere between 1:00 and 2:30 after playing the video from 0:00.

Tested on a new fresh firefox 37 profle. installed V60 and enabled the English subs. Win 7 x64