search

jackun / VLCTube

The Unlicense
16 stars 4 forks source link

Compact volume button is shorter than the other buttons #51

Closed asampal closed 9 years ago

asampal commented 9 years ago

When using the compact volume option, the resulting button inserted among the others is too short.

asampal commented 9 years ago

Added PR #52

jackun commented 9 years ago

Does this work for you? Seems too hacky though. Adds a div next to volume button and then moves it left.

asampal commented 9 years ago

The height looks right now, but I have a couple of comments on the other parts of the compact volume control.

  1. While the video is first playing, the vertical slider's corners aren't rounded. They only become round when the video finishes playing. Also, the knob seems to not be centered on the slider.
  2. I think the text showing the percent value of the slider isn't needed. Moving the knob feels relatively laggy, probably due to the text being refreshed while dragging is happening. My vote would be to not show a textual value.