jackun / VLCTube

The Unlicense
16 stars 4 forks source link

Commit 627df3e broke Firefox 33.0.2 #56

Closed ghost closed 9 years ago

ghost commented 9 years ago

Firefox 33.0.2 + VLC 2.1.5 + VLCTube 59.7 (Commit 23f4b85) = perfect happiness

Firefox 33.0.2 + VLC 2.1.5 + VLCTube 59.7 (Commit 627df3e or after) = total misery

After Commit beginning 627df3e, no longer loads at all.

Console for 627df3e (not working):

0:9:2.786 CSI/tbsd_
0:9:2.787 CSI/_tbnd
0:9:2.788 CSI/hl
0:9:2.826 CSI/bl
0:9:2.873 CSI/jl
POST https://www.youtube.com/watch_fragments_ajax?v=v5lWYsuhFLo&tr=time&frags=guide&spf=load 200 OK
YouTube...user.js (line 62)
TypeError: hd(...) is undefined
...box.yt.install")(a,c,f,b,d,Ad,Bd);var e=hd("DARUDE_SEARCH_TERM").toLowerCase();h...  
www-searchbox.js (line 130, col 293)

Console for 23f4b85 (working):

event: stopped
watch?v...YsuhFLo (line 1235)
GET https://www.youtube.com/user_watch?t=1&asv=3&video_id=v5lWYsuhFLo&ei=S88cVYeFF4PLrwbnkIPwBQ 204 No Content
YouTube...user.js (line 62)
GET https://www.youtube.com/ptracking?video_id=v5lWYs...NVuLJJ&pltype=content&ptk=85ymP8KqT597cQNeihYmu 
YouTube...user.js (line 62)
GET https://www.youtube.com/api/timedtext?type=list&v=v5lWYsuhFLo 200 OK
YouTube...user.js (line 62)
0:10:36.118 CSI/tbsd_
0:10:36.119 CSI/_tbnd
0:10:36.119 CSI/hl
0:10:36.174 CSI/bl
0:10:36.193 CSI/jl
TypeError: hd(...) is undefined
...box.yt.install")(a,c,f,b,d,Ad,Bd);var e=hd("DARUDE_SEARCH_TERM").toLowerCase();h...
www-searchbox.js (line 130, col 293)
POST https://www.youtube.com/watch_fragments_ajax?v=v5lWYsuhFLo&tr=time&frags=guide&spf=load 200 OK
YouTube...user.js (line 62)
jackun commented 9 years ago

Log doesn't show, but I missed adding function to blah: function(arg). Somehow it still worked on Fx36. Did the latest commit fix it?

ghost commented 9 years ago

It works again, thanks. Marquee'n me marvelously.