search

jagenjo / litegraph.js

A graph node engine and editor written in Javascript similar to PD or UDK Blueprints, comes with its own editor in HTML5 Canvas2D. The engine can run client side or server side using Node. It allows to export graphs as JSONs to be included in applications independently.
MIT License
6.85k stars 719 forks source link

NPM package not complete #32

Closed gotwig closed 6 years ago

gotwig commented 6 years ago

Hey,

I know @kriffe is maintaing the NPM, so I'm wondering why is the NPM package not complete?

The editor.js and editor.css is not included, and the demo node files are missing.

Can you please include them?

Thanks

kriffe commented 6 years ago

I usually use npm for production version of projects, not just a mirror of the entire github repo (then we could just use github). Therefore the published files are specified in package.json under files.

Regarding the editor i did not consider it as production code since its not used inside the remaining webglstudio project. I think there is another editor somewhere, and it might benefit from being inside another npm repo.

@jagenjo : Whats your opinion on including the editor code on npm? Should I just add it or is it only for internal demo purpose?

jagenjo commented 6 years ago

@kriffe right now the editor is just for demoing, Im not using it in webgltudio, but it doesnt matter to me if it is inside the npm, Im not using npm in any form so feel free to do what you consider better.

But as you say, maybe I should move the litegraph editor to another repo and add more features.

gotwig commented 6 years ago

I need to modify the editor to the needs of my project, so maybe it doesnt make a lot of sense to bundle something in that people just change anyhow?