search

jagenjo / litegraph.js

A graph node engine and editor written in Javascript similar to PD or UDK Blueprints, comes with its own editor in HTML5 Canvas2D. The engine can run client side or server side using Node. It allows to export graphs as JSONs to be included in applications independently.
MIT License
5.31k stars 602 forks source link

Major change - To Be Discussed, not just blind pulled! #442

Closed daniel-lewis-ab closed 2 months ago

daniel-lewis-ab commented 3 months ago

Hi,

So I went through and cracked open the litegraph.js file into separate JS files. This is a first seemingly necessary step to upgrading and maintaining the code, documenting it, etc.

I wanted discussion as to whether anyone wanted to have this not happen for their particular project.

Please review the changes and decide whether it's a correct path forward for you. I'm going to move on with upgrading my codebase.

AndyP01 commented 2 months ago

Has this been closed without any discussion, or for other reasons?

daniel-lewis-ab commented 2 months ago

I hadn't heard any discussion, and it's been a while.

My fork currently has a AFAIK working partial upgrade to ES6. I'm working on getting the rest of it converted to classes before moving forward to the next step. I'm open to hearing what that ought to be, but there's quite a bit to upgrade to modern JS.

Regards, Daniel

On Fri, Mar 1, 2024 at 11:51 PM Andy @.***> wrote:

Has this been closed without any discussion, or for other reasons?

— Reply to this email directly, view it on GitHub https://github.com/jagenjo/litegraph.js/pull/442#issuecomment-1974477792, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC36LNYJNTO5PEWRLEXTFDTYWFZHDAVCNFSM6AAAAABCVWQRW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZUGQ3TONZZGI . You are receiving this because you modified the open/close state.Message ID: @.***>