search

jaggedsoft / node-binance-api

Node Binance API is an asynchronous node.js library for the Binance API designed to be easy to use.
MIT License
1.58k stars 767 forks source link

depthCache out of sync #129

Closed bkrypt closed 6 years ago

bkrypt commented 6 years ago

Myself and a few others have noticed an issue where the depth cache sometimes goes out of sync, leaving garbage in the order book and chaos in the world.

I'm not sure if any other issues make direction mention of it, but it has been brought up in #125. I'm just creating this issue to have one that is specific to this problem.

bkrypt commented 6 years ago

I believe I've solved this! I just need to tidy it up, and then I'll open a PR. It's late here now though, and I must go to bed, but I'll get around to it as soon as possible tomorrow.

jaggedsoft commented 6 years ago

Thanks for all your hard work!! I appreciate you very much There are a lot of improvements I want to make but time is very limited for me this week Everything you have done so far has been very high quality and well thought out. You're very good at what you do. Thanks again

bkrypt commented 6 years ago

No problem man. It's been a pleasure to help out with a library that's made my life so much easier. And no worries, I know all about limited time and how that goes. Speaking of improvements, feel free to shout if there's anything I can help with in the quest for v0.5.0.