jakeFeldman / strapi-provider-upload-azure-storage

Strapi Provider Upload Azure Storage
MIT License
75 stars 42 forks source link

Added SAS authentication for blob storage #64

Closed devendra-rgb closed 1 year ago

devendra-rgb commented 1 year ago

I modified the blob service client function to make authentication using sas token

devendra-rgb commented 1 year ago

Sure! I will work on these

devendra-rgb commented 1 year ago

@jakeFeldman Please check the new commit I also ran lint to check every thing is correct everything is fine

jakeFeldman commented 1 year ago

Changes look good. Let me run this locally and if everything looks good I'll get this added into the next version! Thanks again for the PR!

devendra-rgb commented 1 year ago

please verify it now it works without a connection string

jakeFeldman commented 1 year ago

Changes look good. I'll test again tonight

devendra-rgb commented 1 year ago

Sure!

devendra-rgb commented 1 year ago

Thank you for the quick response waiting to see the release : )

jakeFeldman commented 1 year ago

@devendra-rgb I'm doing some further testing an I'mm unable to get the sas token to work. Did you have this working locally?

devendra-rgb commented 1 year ago

Yeah

jakeFeldman commented 1 year ago

Interesting I've added my sasToken and I get a 403 [AzureStorage Blob Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature](https://stackoverflow.com/questions/24492790/azurestorage-blob-server-failed-to-authenticate-the-request-make-sure-the-value)

devendra-rgb commented 1 year ago

I will look into it and get with a solution by tonight

jakeFeldman commented 1 year ago

Uploads are working but fetching the images are failing within the strapi ui

devendra-rgb commented 1 year ago

Oh Let me see this then I will have a look how it is forming the url for fetching