search

jakewaldron / PlexEmail

This script aggregates all new TV, movie and music releases for the past configured time then optionally writes to your web directory and sends out an email.
206 stars 32 forks source link

[Feature Request] - Support Music #13

Closed Mawuena closed 8 years ago

Mawuena commented 8 years ago

Hello,

First of all, awesome code, truely ! However never thought of adding a third part to the relases : Music ? It's the only thing missing at this stage even though I know that most people (myself included) use Plex for TV & Movies mostly.

In any case, thanks for the contribution and sharing your code with us all !!

Sincerely,

Mawuena

jakewaldron commented 8 years ago

Hi there,

I'll look into what is needed and what information is needed. Also not sure how best to organize it. Should it be a bit like TV shows? A section for New Artists, New Albums and New Songs?

I'll try to do this over the next month (very little time available to dedicate to updating this script).

Mawuena commented 8 years ago

Oh thank you very much for this. And yes about the section organization, it should be like TV shows

Cordialement / Sincerely

Mawuena Seketeli Sent From My Linux Phone On Feb 18, 2016 01:49, "jakewaldron" notifications@github.com wrote:

Hi there,

I'll look into what is needed and what information is needed. Also not sure how best to organize it. Should it be a bit like TV shows? A section for New Artists, New Albums and New Songs?

I'll try to do this over the next month (very little time available to dedicate to updating this script).

— Reply to this email directly or view it on GitHub https://github.com/jakewaldron/PlexEmail/issues/13#issuecomment-185481628 .

jakewaldron commented 8 years ago

It's still under development, but the initial version to support music can be found in the dev branch. If you are willing to be a guinea pig, I would love any feedback/bug reports. It currently supports new artists and new albums and I plan on modifying the layout a bit over the next week or two (i.e. adding track list to the album sections).

Mawuena commented 8 years ago

Just tested it and it works perfectly. I have a cron that launches it weekly so I'll let you know of bugs and what not as soon as I notices on but for now, it just workes like a charm !

Cordialement / Sincerely

Mawuena Seketeli

On Tue, Feb 23, 2016 at 11:43 PM, jakewaldron notifications@github.com wrote:

It's still under development, but the initial version to support music can be found in the dev branch. If you are willing to be a guinea pig, I would love any feedback/bug reports. It currently supports new artists and new albums and I plan on modifying the layout a bit over the next week or two (i.e. adding track list to the album sections).

— Reply to this email directly or view it on GitHub https://github.com/jakewaldron/PlexEmail/issues/13#issuecomment-187947223 .

Mawuena commented 8 years ago

Sorry, spoke to fast. Noticed that the new artist category doesn't show any pictures even though there is some in my plex server. All the other sections work out perfectly !

Mawuena commented 8 years ago

And if possible to make the descriptions more readable with a little bit of < br > here and there, it'd be perfect.

jakewaldron commented 8 years ago

Thanks for testing. I just checked in a fix for the missing images and also checked in a change to add track lists to the albums.

Mawuena commented 8 years ago

Awesome, will be on the lookout for the new commit to test it out

jakewaldron commented 8 years ago

Oops, forgot to push my changes. They should be in the dev branch now.

Mawuena commented 8 years ago

Just did and it seems to be working perfectly fine. Will toy with it a little bit more and if I notice anything I'll let you know but don't think I will as it seems awesome now ! Definitely ready to be moved to the "master" branch

Next step would be to thing of an easy way to update or auto update or something (without having to redo all the config and what not). Unless it's already done and I'm being a bit of a big dummy ?

jakewaldron commented 8 years ago

There's no good way to update the config file right now, except maybe doing a diff on yours and the new one and adding the new lines. If you use your old one, it should still work with the new script file and it will use the new default values, so that is an option if you don't plan on customizing the new fields from the default.