jakobhellermann / bevy_editor_pls

In-App editor tools for bevy applications
Other
758 stars 78 forks source link

Open window button not working on version 0.8 #96

Closed MatiasLyyra closed 8 months ago

MatiasLyyra commented 8 months ago

After upgrading to bevy 0.13 and bevy_editor_pls version 0.8, I cannot open window dropdown menu anymore.

Basic project to repro the issue:

[dependencies]
bevy = "0.13.0"
bevy_editor_pls = "0.8.0"
use bevy::prelude::*;
use bevy_editor_pls::EditorPlugin;
fn main() {
    App::new()
        .add_plugins(DefaultPlugins)
        .add_plugins(EditorPlugin::default())
        .run();
}

When I run the project, press e and select "open window", nothing happens.

This problem doesn't occur when using bevy version 0.12 and bevy_editor_pls version 0.7. I am running this on Windows 10, if that makes any difference.

tannerntannern commented 8 months ago

I can confirm the same issue for bevy 0.13 on Windows 10. I also tried cargo update to see if my lockfile had any out of date transitive dependencies that would cause this, but the issue remains.

It seems that you can't click any buttons on that top bar, because clicking the play button doesn't work either. You can double-click the bar to go full screen though.

jakobhellermann commented 8 months ago

apparently the logic that used to work to detect double click now breaks the regular interactions, so I've disabled that for now and release 0.8.1 https://github.com/jakobhellermann/bevy_editor_pls/commit/6d953c35bc173a72872b6cc5dec09d79b00e45d0

tannerntannern commented 8 months ago

Thanks so much @jakobhellermann! I appreciate the quick turnaround and your work on this helpful tool in general!

EDIT: For those reading along, you may want to uninstall and reinstall the crate. Initially I thought the bug wasn't fixed but my lock file kept bevy_editor_pls_core 0.8 because bevy_editor_pls 0.8.1 doesn't strictly require the core version to be 0.8.1. Uninstalling and reinstalling got the core package to be the correct version.