jambonz / jambonz-webapp

A simple provisioning web app for jambonz
MIT License
5 stars 21 forks source link

show registration status for carriers that require register #225

Closed davehorton closed 1 year ago

davehorton commented 1 year ago

When defining a carrier that requires jambonz to send outbound registrations the relevant panel looks like this:

image

I would like to enhance this view so that under "Use public IP in Contact" there is a label "Registration status:" with a value showing the current status (ie the most recent response to a register request). So for success it would show:

Registration status: successfully registered (200 OK)

or

Registration status: failed (408 Request TImeout)

This will require changes in the api-server and also possibly in sbc-sip-sidecar as well

davehorton commented 1 year ago

As a further enhancement, it would be nice if the status was a link such that when you click it downloads the pcap for that most recent register request. This will require us to figure out the proper http request to make to homer.

This feature would give people insight into whether their register requests are working and enough information to troubleshoot if they are not

xquanluu commented 1 year ago

Start contributing to this.

davehorton commented 1 year ago

actually, in thinking about this I think it would be better for the status to be shown on the carrier list, e.g.

image

Alongside or next to "active" we could show "registered OK" or "register failed", again each being a link to download a pcap

xquanluu commented 1 year ago

Hi @davehorton I finished the work here. Please help to review related PRs: https://github.com/jambonz/db-helpers/pull/11/files https://github.com/jambonz/sbc-sip-sidecar/pull/19 https://github.com/jambonz/jambonz-api-server/pull/141 https://github.com/jambonz/jambonz-webapp/pull/226

davehorton commented 1 year ago

all looks good, I've merged all but sbc-sip-sidecard which just needs an update to package.json for latest db-helpers

xquanluu commented 1 year ago

Closed this issue as it's done