search

jambonz / jambonz-webapp

A simple provisioning web app for jambonz
MIT License
5 stars 21 forks source link

update to change in jaeger api change #279

Open davehorton opened 1 year ago

davehorton commented 1 year ago

Currently we are querying the internal json api of jaeger using GET /api/v3/traces/${traceId}.

The problem is that while this works for the jaeger-all-in-one component, it does not work for the decomposed architecture where we call jaeger-query to retrieve the data. And the decomposed architecture (e.g splitting functionality into jaeger-agent, jaeger-collector, and jaeger-query) is required in order to save spans in cassandra persistent storage rather than memory.

Furthermore, the docs indicate the api we should be calling is GET /api/traces/${traceId}.

This api does work but it returns data in a different format:

We need to change api-server to call /api/traces/${traceId} so that we can support both types of deployments (in-memory plus persistent storage). The change to api-server is simple but we will need to change the parsing / display logic in the webapp as well.

davehorton commented 1 year ago

actually, the /v3 variant is available in recent docker images - I had been testing with an older image. So I think we are good for now. I will leave this ticket open for when we have time to update to using the grpc api which I do think will be better since it is implied to be more stable, but this is not a high priority at the moment