jamesmontemagno / InAppBillingPlugin

Cross-platform In App Billing Plugin for .NET
MIT License
668 stars 153 forks source link

Upgrade to 7.1 of android billing #631

Closed jamesmontemagno closed 1 day ago

jamesmontemagno commented 2 months ago

Is now available: https://developer.android.com/google/play/billing/migrate-gpblv7

rezamohamed commented 2 months ago

In the Readme there is a mention of 'Version 8 Major Updates', however, nuget only shows 7.1.3. Is the v8 not released yet?

rezamohamed commented 2 months ago

I had to search nuget and found the beta release. Is this it? https://www.nuget.org/packages/Plugin.InAppBilling/8.0.3-beta

jamesmontemagno commented 1 month ago

The versions don't align with Android billing library stuff. 8.0.3-beta uses BillingClient 6.2.1

rezamohamed commented 1 month ago

The versions don't align with Android billing library stuff. 8.0.3-beta uses BillingClient 6.2.1

@jamesmontemagno Sorry, that wasn't very clear. On the readme it says to use the v8 Major Version (the only v8 I see is the beta), and here are you saying don't use the v8 beta? Which is the correct version to use with the Android Billing v7?

jamesmontemagno commented 1 month ago

v8 is now out on stable and that is built against Android Billing v6.2

rezamohamed commented 1 month ago

Thanks for clarifying! will try it out now

rezamohamed commented 1 month ago

@jamesmontemagno still open question on this, should I be targeting 6.2.1 here:

<meta-data android:name="com.google.android.play.billingclient.version" android:value="6.2.1"/>

or the latest v7 version 7.1.1 and change the android:value = "7.1.1"?

https://developer.android.com/google/play/billing/release-notes

jamesmontemagno commented 1 month ago

It is whatever version i built it against. Although you shouldn't have to add it anymore

rezamohamed commented 1 month ago

Although you shouldn't have to add it anymore

Ah even better, I will go ahead and remove <meta-data android:name="com.google.android.play.billingclient.version" android:value="6.2.1"/> from the Android Manifest. Thanks!