jamielob / reloader

More control over hot code push reloading for your production apps. Designed to replace mdg:reload-on-resume and provide a more production-ready approach.
28 stars 22 forks source link

Move to later version of Cordova Splashscreen? #15

Open adamgins opened 7 years ago

adamgins commented 7 years ago

Any reason this is locked to 4.0.0 https://github.com/jamielob/reloader/blob/master/package.js#L10

I think that means it's dependent, right... won't work with later versions?

Newer versions here https://github.com/apache/cordova-plugin-splashscreen/blob/master/RELEASENOTES.md

lorensr commented 7 years ago

Don't think any reason

On Sun, Nov 12, 2017 at 2:59 PM adamgins notifications@github.com wrote:

Any reason this is locked to 4.0.0 https://github.com/jamielob/reloader/blob/master/package.js#L10

I think that means it's dependent, right... won't work with later versions?

Newer versions here https://github.com/apache/cordova-plugin-splashscreen/blob/master/RELEASENOTES.md

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jamielob/reloader/issues/15, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPVmC8uG5Gw1GjBSG8FFW_K6dvA9zmhks5s104kgaJpZM4QbBIM .

adamgins commented 7 years ago

thanks for quick response... should I create a pull request to update it to 4.1.0 , I don't think Cordova.depends has option to do something like ^4.0.0 or does it?

lorensr commented 7 years ago

Sure! Dunno, docs don't say—try it locally by cloning this repo to your packages/ folder

http://docs.meteor.com/api/packagejs.html#PackageCordova-depends

adamgins commented 7 years ago

Will try

BYW if I try and downgrade to 4.0.0 I get this warning

WARNING: Attempting to install plugin cordova-plugin-splashscreen@4.0.0, but it should have a minimum version of 4.0.3 to
         ensure compatibility with the current platform versions. Installing the minimum version for convenience, but you
         should adjust your dependencies.