search

janet-lang / jaylib

Janet bindings to Raylib
MIT License
137 stars 36 forks source link

Fix camera2d_get #47

Closed gree7 closed 1 year ago

gree7 commented 1 year ago

Missing ! at janet_cstrcmps.

sogaiu commented 1 year ago

@AlecTroemel What do you think?

cf. https://github.com/janet-lang/jaylib/commit/6b62d1875fb2843f1fb6a900d21c1f6f0d89cbb8

gree7 commented 1 year ago

Btw. in the put variant, there are the !s: https://github.com/janet-lang/jaylib/blob/36baa1d39fe5e654961ae189660a254cffe0b651/src/types.h#L576 (and put is working for me fine, however get always returns the first case, which is :target).

AlecTroemel commented 1 year ago

"remove backwargs '!' used in cstrcmp" nice I even had a typo in the comment :laughing:. I remember being confused by janet_cstrcmp and whether we need to invert it.

looking at other uses of that function in this codebase it looks like I just got it backwards