search

janvi01 / sql-editor

A web-based application that provides a SQL editor to run queries and display results.
https://sql-editor-online.vercel.app/
MIT License
10 stars 17 forks source link

Display error message for incorrect query #43

Open Tajinder-Dhoot opened 11 months ago

Tajinder-Dhoot commented 11 months ago

Is your feature request related to a problem? Please describe. It is not related to a problem but it would give more precise message to user.

Describe the solution you'd like Message for incorrect query should be clear and separate from empty query message.

Additional context

incorrect query error message (proposed change)

incorrect query error message

empty query error message (already implemented)

empty query error message
Tajinder-Dhoot commented 11 months ago

@janvi01 I have the change ready for PR if you agree on change.

Tajinder-Dhoot commented 11 months ago

@janvi01 - In order to implement this change, another PR (https://github.com/janvi01/sql-editor/pull/46) needs to be approved. Otherwise I am not able to test my changes or I get an error as results array is undefined in one of the scenario. Please review the PR for issue #46.

janvi01 commented 11 months ago

@Tajinder-Dhoot Go ahead.