janxious / CharlesB

Make BattleTech mechs fall down when they miss because that's funny
MIT License
2 stars 2 forks source link

mechs possibly not falling over from weaponsfire #12

Open gnivler opened 6 years ago

gnivler commented 6 years ago

I'm testing with a customized chassisDef to reduce stability damage. I set it lower than the 32 that appears in game, floor maybe. The mech status show its stability is 32/32.

falling happened!
location taking damage: RightLeg
Date: 8/1/2018 10:43:18 AM
--------------------------------------------------
falling damage numbers
pilotSkill: 5
mitigation: 0.2379729
rawFallingDamage: 27.5
mitigationPercent: 24
fallingDamageValue: 20.95575
Date: 8/1/2018 10:43:18 AM
--------------------------------------------------

This was the only thing appearing in the log after opfor shot an unstable mech. The mech doesn't show knocked over. It will eventually fall over from effects I predict, I've seen this happen twice now. Maybe I just created an edge case with my stupid chassisDef...

Seems like the mech wasn't in an unsteady state, more damage put it there, and more damage yet made it fall over. This seems to be tied with stability versus unsteady state. More evidence to the chassisDef foolery.

Update: I think these calls to AddRelativeInstability may be at fault for the weird values... not sure why. https://github.com/janxious/CharlesB/blob/8155543bb69be96e96a143b942de99c2d2b67ad4/CharlesB.cs#L127 https://github.com/janxious/CharlesB/blob/8155543bb69be96e96a143b942de99c2d2b67ad4/CharlesB.cs#L207

gnivler commented 6 years ago

Posting another entry here for the logs, I think this might be better described as somehow getting unexpected stability values. Still not sure if related to this possible issue of a 'standing, fallen' mech.

melee pre-miss stability: 12.71
Date: 8/1/2018 12:08:57 PM
--------------------------------------------------
melee miss numbers
pilotSkill: 8
mitigation: 0.2170271
rawInstabilityToAdd: 0.3
mitigationPercent: 22
instabilityToAdd: 0.2348919
Date: 8/1/2018 12:08:57 PM
--------------------------------------------------
melee post-miss stability: 26.71
Date: 8/1/2018 12:08:57 PM
--------------------------------------------------