search

janxious / CharlesB

Make BattleTech mechs fall down when they miss because that's funny
MIT License
2 stars 2 forks source link

Add knockdown phrases #13

Closed gnivler closed 6 years ago

gnivler commented 6 years ago

Loads from phrases.txt in the mod folder, only when called upon. Small method to generate the phrases based on settings. Application of method before calling HandleKnockdown()s

gnivler commented 6 years ago

thanks for the tips - amended my commit. I think I got away with it in just the one FallHandling class?

Woops, I just found more detailed comments and may not have gotten it done yet.

gnivler commented 6 years ago

awesome thanks again. I'll get er

gnivler commented 6 years ago

I think I might have it now, look better?

janxious commented 6 years ago

Can you check in the phrases file?

gnivler commented 6 years ago

There we go, 15 hand-crafted phrases from my mind and the web. I took out the really weird ones.

janxious commented 6 years ago

Check out the last couple commits on this branch https://github.com/janxious/CharlesB/compare/gnivler-master?expand=1

gnivler commented 6 years ago

I hope this is it! I must have right-clicked Properties when adding the file, didn't notice it went in there. Fixed memoizing and random class

gnivler commented 6 years ago

Hi, not sure if there are additional changes requested? I can't see anything which means little! Glad to work if stuff is incomplete.

janxious commented 6 years ago

@gnivler I think it's done. I just haven't made time to test it since the last changes