Error handling in Side Effects might be broken

jared-dykstra / 180-decibels-website

Website for the (now decommissioned) 180Decibels.com

1 stars 0 forks source link

Open jared-dykstra opened 5 years ago

jared-dykstra commented 5 years ago

Need to test and ensure:

That sagas are indeed forked/spawned and don't block rendering
That a failing saga is restarted and doesn't cause lingering problems: https://github.com/redux-saga/redux-saga/issues/760#issuecomment-273737022

jared-dykstra commented 5 years ago

I noticed that logPageView() appears to be blocking rendering--the whole point of the saga was to no block. (Or switch to react hooks)

jared-dykstra commented 5 years ago

I think everything is ok. It would just be nice to prove it with tests.