search

jasperweyne / helpless-kiwi

Manage members, create and manage activities, send mails and more
Apache License 2.0
11 stars 7 forks source link

Phpstan improvements #269

Closed jasperweyne closed 2 years ago

jasperweyne commented 2 years ago

This PR intends to improve the phpstan baseline. It furthers the integration between phpstan and symfony/doctrine. Moreover, issues that occur in bulk (for example phpunit method calls as static) are mitigated as well. The intention for this PR is to improve quality of life for developers a bit, since a lot of the baseline errors could be easily fixed (as seen here!), yet it is a tedious process to do so.

Since a lot of method signatures were touched, sonarcloud doesn't approve of the current coverage. Given the fact that we're currently working on improving coverage and given the fact that this PR doesn't really touch code, I feel like it's best to omit the coverage requirement for this specific PR, as it improves the speed that other PRs can be written.

sonarcloud[bot] commented 2 years ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

45.3% 45.3% Coverage
1.9% 1.9% Duplication

sonarcloud[bot] commented 2 years ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

53.1% 53.1% Coverage
1.8% 1.8% Duplication