jasperweyne / helpless-kiwi

Manage members, create and manage activities, send mails and more
Apache License 2.0
11 stars 7 forks source link

Send e-mails to participants #294

Closed jasperweyne closed 2 years ago

jasperweyne commented 2 years ago

This PR adds a number of buttons for admins & organisers, which allows them to send e-mails to participants for activities. A button is added for anyone individually who has registered, deregistered or is on the reserve list.

Additionally, a button is added to send a mail to all registered participants, which respects the registrants privacy by using the BCC field. The system works by utilizing the "mailto:" URL construct.

A-Daneel commented 2 years ago

A quick reply, from what I've seen. I think this is a very nice addition, and a nicer solution then you originally suggested in #87.

Personally I don't see the use of sending a mail to a singular participant, however there is no reason to remove it so I would suggest keeping it.

Now, little thing about design

afbeelding With the addition of a second(third?) action I feel it turns out a little crowded, I don't see why "Bewerken" is a separate option (also, why is it called "bewerk" while it's function is adding an remark.).

_git Same here, why do we add these options on the bottom of the list instead of above them?

Let me end by saying that I have exactly no feeling about design. But I do feel that if we're adding more "buttons" we should take a moment to think about it.

jasperweyne commented 2 years ago

I agree that the three actions per row is making things a little crowded by now, but I don't see a quick fix for this. Regarding the actions at the bottom of the table, these actions modify the content of the activity, while the actions at the top modify the activity itself. I know that from a technical standpoint, there's little difference, but conceptually, I feel there is. That is why the "Deelnemers mailen" has been added below.

Basically, although I agree with the premise that stuff is getting too crowded, I feel that we should address that with #251 for a fully improved solution. For now, I feel like this PR has enough added value to justify the UX costs that the amount of buttons creates.

Regarding the "Bewerk" button being in a seperate column, although I feel that's an issue not fully within the scope of this PR, I'm happy to include those changes as it's a small edit, an extra commit will follow shortly.

A-Daneel commented 2 years ago

then, for now, how about we add "bewerk" to the actions (if you have a better naming idea, please do so!) and separate the actions (as example "afmelden - mailen - bewerken"). that way it for now at least clear that they are separate buttons. and we can do a big overhaul of the design later.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

A-Daneel commented 2 years ago

Still not completely happy with the word "bewerken", since it only allows you to add/edit a comment. But maybe that's more for an other issue. For now your additions haven't added any more clutter, so I'm fine with merging it.