gitguardian[bot]
commented
1 year ago ⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secret in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [336171](https://dashboard.gitguardian.com/incidents/336171?occurrence=49908569) | Generic High Entropy Secret | 8387345874ce280566943166cba1e122b16231d4 | .github/workflows/db.yml | [View secret](https://github.com/jasperweyne/helpless-kiwi/commit/8387345874ce280566943166cba1e122b16231d4#diff-2849462b60c56e2082ec2155124e370c317222081a1d7afdd0be89b72d1d83faR47) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
mattijsgietman
This PR acomplishes a bug fix aswell as a FR. To get into more detail on what has exactly been done, please read below.
Bug Fix: "500 on creating duplicate account" For this fix I modified the file: "SecurityController.php". When submitting the form we get the e-mailadress and check our DB to see if the mail already exists. If this is indeed the case we'll show the error message: "E-mail bestaat al". If this is not the case account creation will continue.
FR: "New activity form should automatically create default price option" For this FR I altered the "ActivityController.php" file and added a price option to the form, I added a label to the file "PriceOptionType.php". Furthermore, I added tests to the test-file to test this feature.